Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1333358

[PATCH] exofs: fix inode formatting, should be %llx and not %llu

From Colin King <colin.king@canonical.com>
Newsgroups linux.kernel
Subject [PATCH] exofs: fix inode formatting, should be %llx and not %llu
Date 2016-02-13 21:30 +0100
Message-ID <r1OZj-1dF-1@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


From: Colin Ian King <colin.king@canonical.com>

The inode is printed with a %llu format specifier when the
intention is to print a hexadecimal value. Trivial fix to
use %llx instead.  Found with smatch static analysis:

fs/exofs/dir.c:138 exofs_check_page() warn: '0x' prefix is
  confusing together with '%llu' specifier

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fs/exofs/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/exofs/dir.c b/fs/exofs/dir.c
index e5bb2ab..9a8eba6 100644
--- a/fs/exofs/dir.c
+++ b/fs/exofs/dir.c
@@ -137,7 +137,7 @@ Espan:
 bad_entry:
 	EXOFS_ERR(
 		"ERROR [exofs_check_page]: bad entry in directory(0x%lx): %s - "
-		"offset=%lu, inode=0x%llu, rec_len=%d, name_len=%d\n",
+		"offset=%lu, inode=0x%llx, rec_len=%d, name_len=%d\n",
 		dir->i_ino, error, (page->index<<PAGE_CACHE_SHIFT)+offs,
 		_LLU(le64_to_cpu(p->inode_no)),
 		rec_len, p->name_len);
-- 
2.7.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] exofs: fix inode formatting, should be %llx and not %llu Colin King <colin.king@canonical.com> - 2016-02-13 21:30 +0100

csiph-web