Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1333346

Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to mutex_optimistic_spin()

From Davidlohr Bueso <dave@stgolabs.net>
Newsgroups linux.kernel
Subject Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to mutex_optimistic_spin()
Date 2016-02-13 19:20 +0100
Message-ID <r1MXw-8rP-3@gated-at.bofh.it> (permalink)
References <r1pRg-1EI-13@gated-at.bofh.it> <r1pRg-1EI-11@gated-at.bofh.it> <r1svM-3ox-19@gated-at.bofh.it> <r1ued-4Bn-1@gated-at.bofh.it> <r1Hl8-4EJ-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sat, 13 Feb 2016, Peter Zijlstra wrote:

>Can't see it do that, also, if it were to do that, we'd not be here
>since having a waiter would then mean no spinners and no starvation
>etc..

I was having a hard time understanding why on earth you didn't see that. And yes
I was also wondering why it was even there... but I was looking at -next, where we
have Ding's original patch b9ce3647b4901071b0dd35d62954a4bb0e5ba1d1.... Paul, could
you drop this patch?

But yeah, I do agree that waiters should also do the mutex_can_spin_on_owner()
check unless I'm missing something subtle from Waiman.

Thanks,
Davidlohr

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] locking/mutex: Enable optimistic spinning of lock waiter Waiman Long <Waiman.Long@hpe.com> - 2016-02-12 18:40 +0100
  [PATCH v2 1/4] locking/mutex: Add waiter parameter to mutex_optimistic_spin() Waiman Long <Waiman.Long@hpe.com> - 2016-02-12 18:40 +0100
    Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to  mutex_optimistic_spin() Peter Zijlstra <peterz@infradead.org> - 2016-02-12 21:30 +0100
      Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to  mutex_optimistic_spin() Davidlohr Bueso <dave@stgolabs.net> - 2016-02-12 23:20 +0100
        Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to  mutex_optimistic_spin() Peter Zijlstra <peterz@infradead.org> - 2016-02-13 13:20 +0100
          Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to  mutex_optimistic_spin() Davidlohr Bueso <dave@stgolabs.net> - 2016-02-13 19:20 +0100
        Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to  mutex_optimistic_spin() Jason Low <jason.low2@hp.com> - 2016-02-16 03:20 +0100
          Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to  mutex_optimistic_spin() Jason Low <jason.low2@hp.com> - 2016-02-16 03:30 +0100
            Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to  mutex_optimistic_spin() Peter Zijlstra <peterz@infradead.org> - 2016-02-16 10:00 +0100
              Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to mutex_optimistic_spin() Waiman Long <waiman.long@hpe.com> - 2016-02-17 03:00 +0100
      Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to mutex_optimistic_spin() Waiman Long <waiman.long@hpe.com> - 2016-02-15 23:10 +0100
    Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to  mutex_optimistic_spin() Peter Zijlstra <peterz@infradead.org> - 2016-02-12 21:50 +0100
      Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to mutex_optimistic_spin() Waiman Long <waiman.long@hpe.com> - 2016-02-16 02:30 +0100
        Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to  mutex_optimistic_spin() Jason Low <jason.low2@hp.com> - 2016-02-16 04:10 +0100
          Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to mutex_optimistic_spin() Waiman Long <waiman.long@hpe.com> - 2016-02-16 04:40 +0100
    Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to  mutex_optimistic_spin() Davidlohr Bueso <dave@stgolabs.net> - 2016-02-12 23:10 +0100
    Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to  mutex_optimistic_spin() Davidlohr Bueso <dave@stgolabs.net> - 2016-02-12 23:10 +0100
      Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to mutex_optimistic_spin() Waiman Long <waiman.long@hpe.com> - 2016-02-16 01:10 +0100
  [PATCH v2 3/4] locking/mutex: Avoid missed wakeup of mutex waiter Waiman Long <Waiman.Long@hpe.com> - 2016-02-12 18:40 +0100
  [PATCH v2 2/4] locking/mutex: Enable optimistic spinning of woken task in wait queue Waiman Long <Waiman.Long@hpe.com> - 2016-02-12 18:40 +0100
  Re: [PATCH v2 0/4] locking/mutex: Enable optimistic spinning of lock  waiter Peter Zijlstra <peterz@infradead.org> - 2016-02-16 10:00 +0100
    Re: [PATCH v2 0/4] locking/mutex: Enable optimistic spinning of lock  waiter Waiman Long <waiman.long@hpe.com> - 2016-02-17 03:00 +0100

csiph-web