Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1333340

Re: mfd: as3711: set regmap config reg counts properly

From "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Newsgroups linux.kernel
Subject Re: mfd: as3711: set regmap config reg counts properly
Date 2016-02-13 17:10 +0100
Message-ID <r1KVJ-78x-15@gated-at.bofh.it> (permalink)
References <qX8ci-Zu-5@gated-at.bofh.it> <r12UF-3l3-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 11.02.2016 18:07, Lee Jones wrote:
> On Sun, 31 Jan 2016, Maciej S. Szmigiero wrote:
> 
>> Regmap config max_register field should contain number of
>> device last register, however num_reg_defaults_raw field
>> should be set to register count instead
>> (usually one register more than max_register).
>>
>> as3711 driver had both of these fields set to the same value,
>> fix this by introducing separate defines for max register
>> number and total count of registers.
>>
>> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
>> ---
>>  drivers/mfd/as3711.c       | 4 ++--
>>  include/linux/mfd/as3711.h | 3 ++-
>>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> These 3 patches should really be submitted as a threaded set, so they
> stay together in one's inbox.
> 
> Also, please submit patches using the subject line format expected by
> the subsystem.
> 
> `git log --oneline -- <subsystem>` helps with this.
> 
> As you're a first time offender, I'll fix this for you this time.
> 
> Applied, thanks.

Thanks,
Maciej

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

Re: mfd: as3711: set regmap config reg counts properly Lee Jones <lee.jones@linaro.org> - 2016-02-11 18:10 +0100
  Re: mfd: as3711: set regmap config reg counts properly "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2016-02-13 17:10 +0100

csiph-web