Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1333304

Re: [PATCH net] net: dsa: mv88e6xxx: do not leave reserved VLANs

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH net] net: dsa: mv88e6xxx: do not leave reserved VLANs
Date 2016-02-13 12:10 +0100
Message-ID <r1Gfo-3Vl-21@gated-at.bofh.it> (permalink)
References <qYTVx-4gQ-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Fri,  5 Feb 2016 14:07:14 -0500

> BRIDGE_VLAN_FILTERING automatically adds a newly bridged port to the
> VLAN with the bridge's default_pvid.
> 
> The mv88e6xxx driver currently reserves VLANs 4000+ for unbridged ports
> isolation. When a port joins a bridge, it leaves its reserved VLAN. When
> a port leaves a bridge, it joins again its reserved VLAN.
> 
> But if the VLAN filtering is disabled, or if this hardware VLAN is
> already in use, the bridged port ends up with no default VLAN, and the
> communication with the CPU is thus broken.
> 
> To fix this, make a port join its reserved VLAN once on setup, never
> leave it, and restore its PVID after another one was eventually used.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Applied.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH net] net: dsa: mv88e6xxx: do not leave reserved VLANs David Miller <davem@davemloft.net> - 2016-02-13 12:10 +0100

csiph-web