Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1332426
| From | Matthias Brugger <matthias.bgg@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 5/6] serial: 8250/mediatek: fix building with SERIAL_8250=m |
| Date | 2016-02-12 00:20 +0100 |
| Message-ID | <r18GK-79j-9@gated-at.bofh.it> (permalink) |
| References | <r11Ff-2lT-5@gated-at.bofh.it> <r11Fg-2lT-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11/02/16 16:41, Arnd Bergmann wrote: > The Mediatek 8250 driver has a 'bool' Kconfig symbol, but that > breaks when SERIAL_8250 is a loadable module: > > drivers/tty/built-in.o: In function `mtk8250_set_termios': > :(.text+0x1bee8): undefined reference to `serial8250_do_set_termios' > :(.text+0x1bf10): undefined reference to `uart_get_baud_rate' > :(.text+0x1c09c): undefined reference to `uart_get_divisor' > drivers/tty/built-in.o: In function `mtk8250_do_pm': > :(.text+0x1c0d0): undefined reference to `serial8250_do_pm' > drivers/tty/built-in.o: In function `mtk8250_probe': > :(.text+0x1c2e4): undefined reference to `serial8250_register_8250_port' > serial/8250/8250_mtk.c:287:242: error: data definition has no type or storage class [-Werror] > serial/8250/8250_mtk.c:287:122: error: 'mtk8250_platform_driver_init' defined but not used [-Werror=unused-function] > > This changes the symbol to a 'tristate', so the dependency on > SERIAL_8250 also works when that is set to 'm'. > To actually build the driver, we also need to include <linux/module.h>. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 5/6] serial: 8250/mediatek: fix building with SERIAL_8250=m Arnd Bergmann <arnd@arndb.de> - 2016-02-11 16:50 +0100
Re: [PATCH v2 5/6] serial: 8250/mediatek: fix building with SERIAL_8250=m Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-11 17:20 +0100
Re: [PATCH v2 5/6] serial: 8250/mediatek: fix building with SERIAL_8250=m Arnd Bergmann <arnd@arndb.de> - 2016-02-11 17:40 +0100
Re: [PATCH v2 5/6] serial: 8250/mediatek: fix building with SERIAL_8250=m Matthias Brugger <matthias.bgg@gmail.com> - 2016-02-12 00:20 +0100
Re: [PATCH v2 5/6] serial: 8250/mediatek: fix building with SERIAL_8250=m Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-12 10:50 +0100
csiph-web