Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1332377

[PATCH v42 2/6] clk: WARN_ON about to disable a critical clock

From Michael Turquette <mturquette@baylibre.com>
Newsgroups linux.kernel
Subject [PATCH v42 2/6] clk: WARN_ON about to disable a critical clock
Date 2016-02-11 22:30 +0100
Message-ID <r16Yi-5Zm-9@gated-at.bofh.it> (permalink)
References <r16OB-5Vk-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Lee Jones <lee.jones@linaro.org>

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Michael Turquette <mturquette@baylibre.com>
---
 drivers/clk/clk.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 993f775..39f9527 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -575,6 +575,9 @@ static void clk_core_unprepare(struct clk_core *core)
 	if (WARN_ON(core->prepare_count == 0))
 		return;
 
+	if (WARN_ON(core->prepare_count == 1 && core->flags & CLK_IS_CRITICAL))
+		return;
+
 	if (--core->prepare_count > 0)
 		return;
 
@@ -680,6 +683,9 @@ static void clk_core_disable(struct clk_core *core)
 	if (WARN_ON(core->enable_count == 0))
 		return;
 
+	if (WARN_ON(core->enable_count == 1 && core->flags & CLK_IS_CRITICAL))
+		return;
+
 	if (--core->enable_count > 0)
 		return;
 
-- 
2.1.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v42 0/6] critical clocks and handoff clocks Michael Turquette <mturquette@baylibre.com> - 2016-02-11 22:20 +0100
  [PATCH v42 6/6] clk: introduce CLK_ENABLE_HAND_OFF flag Michael Turquette <mturquette@baylibre.com> - 2016-02-11 22:20 +0100
  [PATCH v42 4/6] clk: per-user clk prepare & enable ref counts Michael Turquette <mturquette@baylibre.com> - 2016-02-11 22:30 +0100
    Re: [PATCH v42 4/6] clk: per-user clk prepare & enable ref counts Stephen Boyd <sboyd@codeaurora.org> - 2016-02-13 02:20 +0100
  [PATCH v42 1/6] clk: Allow clocks to be marked as CRITICAL Michael Turquette <mturquette@baylibre.com> - 2016-02-11 22:30 +0100
    Re: [PATCH v42 1/6] clk: Allow clocks to be marked as CRITICAL Lee Jones <lee.jones@linaro.org> - 2016-02-12 09:10 +0100
    Re: [PATCH v42 1/6] clk: Allow clocks to be marked as CRITICAL Stephen Boyd <sboyd@codeaurora.org> - 2016-02-13 02:20 +0100
      Re: [PATCH v42 1/6] clk: Allow clocks to be marked as CRITICAL Stephen Boyd <sboyd@codeaurora.org> - 2016-02-19 03:10 +0100
  [PATCH v42 2/6] clk: WARN_ON about to disable a critical clock Michael Turquette <mturquette@baylibre.com> - 2016-02-11 22:30 +0100
    Re: [PATCH v42 2/6] clk: WARN_ON about to disable a critical clock Stephen Boyd <sboyd@codeaurora.org> - 2016-02-13 02:20 +0100
  [PATCH v42 3/6] clk: Provide OF helper to mark clocks as CRITICAL Michael Turquette <mturquette@baylibre.com> - 2016-02-11 22:30 +0100
    Re: [PATCH v42 3/6] clk: Provide OF helper to mark clocks as CRITICAL Lee Jones <lee.jones@linaro.org> - 2016-02-12 09:10 +0100
    Re: [PATCH v42 3/6] clk: Provide OF helper to mark clocks as CRITICAL Stephen Boyd <sboyd@codeaurora.org> - 2016-02-13 02:10 +0100
  Re: [PATCH v42 0/6] critical clocks and handoff clocks Lee Jones <lee.jones@linaro.org> - 2016-02-12 09:10 +0100

csiph-web