Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1332305
| From | Tomasz Nowicki <tn@semihalf.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V4 22/23] arm64, pci, acpi: Assign legacy IRQs once device is enable. |
| Date | 2016-02-11 19:50 +0100 |
| Message-ID | <r14tt-4eC-45@gated-at.bofh.it> (permalink) |
| References | <qYvTc-53o-7@gated-at.bofh.it> <qYw2T-57e-39@gated-at.bofh.it> <r0Y4G-8bX-7@gated-at.bofh.it> <r134m-3on-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11.02.2016 18:17, Lorenzo Pieralisi wrote:
> Here (on top of your series), ready for flak.
>
> Lorenzo
>
> -- >8 --
> diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c
> index 0b53262..26ee291 100644
> --- a/arch/arm64/kernel/pci.c
> +++ b/arch/arm64/kernel/pci.c
> @@ -45,28 +45,23 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,
> */
> int pcibios_enable_device(struct pci_dev *dev, int mask)
> {
> - int ret;
> -
> if (pci_has_flag(PCI_PROBE_ONLY))
> return 0;
>
> - ret = pci_enable_resources(dev, mask);
> - if (ret < 0)
> - return ret;
> -
> -#ifdef CONFIG_ACPI
> - if (!pci_dev_msi_enabled(dev))
> - return acpi_pci_irq_enable(dev);
> -#endif
> - return 0;
> + return pci_enable_resources(dev, mask);
> }
>
> /*
> - * Try to assign the IRQ number from DT when adding a new device
> + * Try to assign the IRQ number when probing a new device
> */
> -int pcibios_add_device(struct pci_dev *dev)
> +int pcibios_alloc_irq(struct pci_dev *dev)
> {
> - dev->irq = of_irq_parse_and_map_pci(dev, 0, 0);
> + if (acpi_disabled)
> + dev->irq = of_irq_parse_and_map_pci(dev, 0, 0);
> +#ifdef CONFIG_ACPI
> + else
> + return acpi_pci_irq_enable(dev);
> +#endif
>
> return 0;
> }
I miss that way of solving the problem. OK lets try this way. I will
integrate it.
Tomasz
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH V4 22/23] arm64, pci, acpi: Assign legacy IRQs once device is enable. Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-02-11 13:00 +0100
Re: [PATCH V4 22/23] arm64, pci, acpi: Assign legacy IRQs once device is enable. Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-02-11 18:20 +0100
Re: [PATCH V4 22/23] arm64, pci, acpi: Assign legacy IRQs once device is enable. Tomasz Nowicki <tn@semihalf.com> - 2016-02-11 19:50 +0100
Re: [PATCH V4 22/23] arm64, pci, acpi: Assign legacy IRQs once device is enable. Tomasz Nowicki <tn@semihalf.com> - 2016-02-11 19:50 +0100
csiph-web