Re: [GIT PULL] workqueue fixes for v4.5-rc3

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] workqueue fixes for v4.5-rc3
Date	2016-02-11 20:00 +0100
Message-ID	<r14D8-4iJ-5@gated-at.bofh.it> (permalink)
References	<r0GKv-5hG-25@gated-at.bofh.it> <r0Ijg-6oz-7@gated-at.bofh.it> <r0UNs-6c7-11@gated-at.bofh.it> <r14a7-44q-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Linus,

On Thu, 11 Feb 2016, Linus Torvalds wrote:

> On Thu, Feb 11, 2016 at 12:18 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> > That certainly makes sense. So we should use a common debug option to force
> > the 'schedule remote' machinery for all interesting subsystems instead of
> > creating an extra option for each.
> 
> Yeah, let's make it easy to use and enable.
> 
> If it was split, the options would likely interact anyway (ie any
> option that enables "add_timer()" to run on arbitrary cpu's wouldl
> automatically also affect "queue_delayed_work()"), so it's not like it
> would really be truly independent issues anyway.
> 
> And if it does show an oops or other problem due to some broken
> expectations, I'd hope the oops should be enough to show what the
> problem is. It did for the vmstat case.

while playing around with it and wondering where to put the command line
option, I wondered whether it makes sense to tie this to debugobjects.

If stuff goes bad, then state corruptions of the involved objects (timers,
work ..) are likely to happen, so having debugobjects enabled along with that
force RR scheme makes a lot of sense.

Thoughts?

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[GIT PULL] workqueue fixes for v4.5-rc3 Tejun Heo <tj@kernel.org> - 2016-02-10 18:30 +0100
  Re: [GIT PULL] workqueue fixes for v4.5-rc3 Linus Torvalds <torvalds@linux-foundation.org> - 2016-02-10 20:10 +0100
    Re: [GIT PULL] workqueue fixes for v4.5-rc3 Thomas Gleixner <tglx@linutronix.de> - 2016-02-11 09:30 +0100
      Re: [GIT PULL] workqueue fixes for v4.5-rc3 Linus Torvalds <torvalds@linux-foundation.org> - 2016-02-11 19:30 +0100
        Re: [GIT PULL] workqueue fixes for v4.5-rc3 Linus Torvalds <torvalds@linux-foundation.org> - 2016-02-11 20:00 +0100
        Re: [GIT PULL] workqueue fixes for v4.5-rc3 Thomas Gleixner <tglx@linutronix.de> - 2016-02-11 20:00 +0100

csiph-web