Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1332260

Re: [PATCH] misc: panel, convert struct to bitmap

From Willy TARREAU <wtarreau@haproxy.com>
Newsgroups linux.kernel
Subject Re: [PATCH] misc: panel, convert struct to bitmap
Date 2016-02-11 18:40 +0100
Message-ID <r13nI-3uV-7@gated-at.bofh.it> (permalink)
References <r0YxJ-bS-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Feb 11, 2016 at 01:29:23PM +0100, Jiri Slaby wrote:
> From: Daniel Chromik <daniel.chromik@seznam.cz>
> 
> There is an anonymous struct which is actually used as a bitmap. So
> convert the struct to a bitmap and change code accordingly where
> needed.
> 
> This also allows for a cleanup of set_data_bits and set_ctrl_bits as
> they can use a common helper now. The helper can also be converted to
> a for loop instead of doing bit OR. And given it is a for loop now,
> bit masking (using BIT_MSK) is moved from the callers there too.
> 
> Signed-off-by: Daniel Chromik <daniel.chromik@seznam.cz>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Willy Tarreau <willy@haproxy.com>
> Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>

Acked-by: Willy Tarreau <willy@haproxy.com>

Thanks,
Willy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] misc: panel, convert struct to bitmap Jiri Slaby <jslaby@suse.cz> - 2016-02-11 13:30 +0100
  Re: [PATCH] misc: panel, convert struct to bitmap Willy TARREAU <wtarreau@haproxy.com> - 2016-02-11 18:40 +0100

csiph-web