Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1332263

Re: [PATCH 3.12 32/64] unix: properly account for FDs passed over unix sockets

Show all headers | View raw

Hi Jiri,

On Thu, Feb 11, 2016 at 02:59:08PM +0100, Jiri Slaby wrote:
> From: willy tarreau <w@1wt.eu>
> 
> 3.12-stable review patch.  If anyone has any objections, please let me know.
> 
> ===============
> 
> [ Upstream commit 712f4aad406bb1ed67f3f98d04c044191f0ff593 ]
> 
> It is possible for a process to allocate and accumulate far more FDs than
> the process' limit by sending them over a unix socket then closing them
> to keep the process' fd count low.
> 
> This change addresses this problem by keeping track of the number of FDs
> in flight per user and preventing non-privileged processes from having
> more FDs in flight than their configured FD limit.
> 
> Reported-by: socketpair@gmail.com
> Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Mitigates: CVE-2013-4312 (Linux 2.0+)
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> Signed-off-by: Willy Tarreau <w@1wt.eu>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>

A possible issue was reported regarding this patch, and Hannes
implemented a fix that's not yet in mainline. I guess it's
preferable to postpone this patch for now.

Thanks,
Willy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3.12 32/64] unix: properly account for FDs passed over unix sockets Jiri Slaby <jslaby@suse.cz> - 2016-02-11 15:20 +0100
  Re: [PATCH 3.12 32/64] unix: properly account for FDs passed over unix sockets Willy Tarreau <w@1wt.eu> - 2016-02-11 18:40 +0100
    Re: [PATCH 3.12 32/64] unix: properly account for FDs passed over  unix sockets Jiri Slaby <jslaby@suse.cz> - 2016-02-12 09:00 +0100
      Re: [PATCH 3.12 32/64] unix: properly account for FDs passed over  unix sockets Philipp Hahn <pmhahn@pmhahn.de> - 2016-02-12 09:50 +0100
        Re: [PATCH 3.12 32/64] unix: properly account for FDs passed over unix sockets Willy Tarreau <w@1wt.eu> - 2016-02-12 10:10 +0100

csiph-web