Re: [PATCH v2] ARM: mm: mark section-aligned portion of rodata NX

From	Russell King - ARM Linux <linux@arm.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] ARM: mm: mark section-aligned portion of rodata NX
Date	2016-02-11 19:10 +0100
Message-ID	<r13QJ-3XL-9@gated-at.bofh.it> (permalink)
References	<qDcBR-2jb-37@gated-at.bofh.it> <qDlc6-7Nx-1@gated-at.bofh.it> <qDvl9-5U7-53@gated-at.bofh.it> <qTRhE-1dO-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 22, 2016 at 01:19:03PM -0800, Kees Cook wrote:
> On Tue, Dec 8, 2015 at 10:38 AM, Kees Cook <keescook@chromium.org> wrote:
> > On Mon, Dec 7, 2015 at 11:47 PM, Ard Biesheuvel
> > <ard.biesheuvel@linaro.org> wrote:
> >> On 7 December 2015 at 23:35, Kees Cook <keescook@chromium.org> wrote:
> >>>  /*
> >>> + * Without CONFIG_DEBUG_ALIGN_RODATA, __start_rodata_section_aligned will
> >>> + * be the first section-aligned location after __start_rodata. Otherwise,
> >>> + * it will be equal to __start_rodata.
> >>> + */
> >>> +__start_rodata_section_aligned = ALIGN(__start_rodata, 1 << SECTION_SHIFT);
...

I'm afraid this causes build errors on two configurations:

./arch/arm/kernel/vmlinux.lds:701: undefined symbol `SECTION_SHIFT' referenced in expression

which I think is down to the new __start_rodata_section_aligned line.

Olof's builder errored out with this for both allnoconfig and
lpc18xx_defconfig builds.  Both probably due to CONFIG_MMU being
unset, and hence no definition for SECTION_SHIFT.

I think you need to make this conditional on CONFIG_MMU.

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] ARM: mm: mark section-aligned portion of rodata NX Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-11 19:10 +0100
  Re: [PATCH v2] ARM: mm: mark section-aligned portion of rodata NX Arnd Bergmann <arnd@arndb.de> - 2016-02-12 10:50 +0100
    Re: [PATCH v2] ARM: mm: mark section-aligned portion of rodata NX Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-15 09:50 +0100

csiph-web