Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1332223

Re: [PATCH] rdma: amso1100: c2_provider: Use netdev_dbg()

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 02/06/2016 10:11 AM, Amitoj Kaur Chawla wrote:
> Replace generic pr_debug() with netdev_dbg() for net devices.
> 
> Found using Coccinelle. The semantic patch used to find this is as
> follows:
> 
> //<smpl>
> @@
> expression e;
> identifier f,i;
> position p;
> @@
> 
> f(...,struct net_device *i,...) {
>   ...
> -  pr_debug@p(e);
> +  netdev_dbg(i, e);
>   ...
> }
> //</smpl>
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>

This driver has been removed entire as of 4.5-rc2, so this patch can no
longer be applied.

> ---
>  drivers/staging/rdma/amso1100/c2_provider.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rdma/amso1100/c2_provider.c b/drivers/staging/rdma/amso1100/c2_provider.c
> index e44ad22..75a7de5 100644
> --- a/drivers/staging/rdma/amso1100/c2_provider.c
> +++ b/drivers/staging/rdma/amso1100/c2_provider.c
> @@ -659,7 +659,7 @@ static int c2_pseudo_up(struct net_device *netdev)
>  	if (!ind)
>  		return 0;
>  
> -	pr_debug("adding...\n");
> +	netdev_dbg(netdev, "adding...\n");
>  	for_ifa(ind) {
>  #ifdef DEBUG
>  		u8 *ip = (u8 *) & ifa->ifa_address;
> @@ -684,7 +684,7 @@ static int c2_pseudo_down(struct net_device *netdev)
>  	if (!ind)
>  		return 0;
>  
> -	pr_debug("deleting...\n");
> +	netdev_dbg(netdev, "deleting...\n");
>  	for_ifa(ind) {
>  #ifdef DEBUG
>  		u8 *ip = (u8 *) & ifa->ifa_address;
> 


-- 
Doug Ledford <dledford@redhat.com>
              GPG KeyID: 0E572FDD

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] rdma: amso1100: c2_provider: Use netdev_dbg() Doug Ledford <dledford@redhat.com> - 2016-02-11 17:30 +0100

csiph-web