Re: [PATCH] MIPS: pci-mt7620: Fix return value check in mt7620_pci_probe()

From	Ralf Baechle <ralf@linux-mips.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] MIPS: pci-mt7620: Fix return value check in mt7620_pci_probe()
Date	2016-02-10 10:10 +0100
Message-ID	<r0yWC-dc-17@gated-at.bofh.it> (permalink)
References	<qZc25-8te-1@gated-at.bofh.it> <qZdhx-Qy-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Feb 06, 2016 at 04:40:03PM +0100, John Crispin wrote:

> On 06/02/2016 15:24, weiyj_lk@163.com wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> > 
> > In case of error, the function devm_ioremap_resource() returns
> > ERR_PTR() and never returns NULL. The NULL test in the return
> > value check should be replaced with IS_ERR().
> > 
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Hi,
> 
> thanks for the fix.
> 
> Acked-by: John Crispin <blogic@openwrt.org>
> 
> @Ralf: can you merge this via LMO with the next PR please ?
> 
> @mbgg: ignore the patch please it is for the legacy MIPS SoCs

Applied.  Thanks folks,

  Ralf

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] MIPS: pci-mt7620: Fix return value check in  mt7620_pci_probe() Ralf Baechle <ralf@linux-mips.org> - 2016-02-10 10:10 +0100

csiph-web