Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1330896

Re: [PATCH V4 6/6] cpufreq: governor: Create and traverse list of policy_dbs to fix lockdep

From Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH V4 6/6] cpufreq: governor: Create and traverse list of policy_dbs to fix lockdep
Date 2016-02-10 06:20 +0100
Message-ID <r0vm2-6f8-3@gated-at.bofh.it> (permalink)
References <r07jI-6AS-3@gated-at.bofh.it> <r07jJ-6AS-27@gated-at.bofh.it> <r0n57-Gp-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 09-02-16, 21:23, Rafael J. Wysocki wrote:
> > +	count = dbs_data->usage_count--;
> 
> This appears to be planting a bug.
> 
> The way you wrote it the decrementation will take place after the assignment, so
> count will contain the old value.

Oh crap, what was I smoking :)

-- 
viresh

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH V4 6/6] cpufreq: governor: Create and traverse list of policy_dbs to fix lockdep "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-09 21:30 +0100
  Re: [PATCH V4 6/6] cpufreq: governor: Create and traverse list of  policy_dbs to fix lockdep Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-10 06:20 +0100

csiph-web