Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1330874

Re: [PATCH] clk: clk_register: Correctly initialize enable_count

Show all headers | View raw

Hi,

El 09/02/16 a las 19:48, Rhyland Klein escribió:
> When clocks are registered, they could be enabled already in
> hardware. As of now, the enable count will start at 0. When this
> happens, it means a clock is enabled and the framework doesn't know
> that, so it will always report it as disabled.

Keep in mind that during the boot process, towards the end, unused
clocks get disabled, so the state remains in sync. If suddenly the
enable_count on unused clocks is not 0, this will break and unused
clocks will remain on, wasting power.

http://lxr.free-electrons.com/source/drivers/clk/clk.c#L244

What issue were you having that prompted you to write this patch?

Cheers,
Emilio

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clk: clk_register: Correctly initialize enable_count Rhyland Klein <rklein@nvidia.com> - 2016-02-09 23:50 +0100
  Re: [PATCH] clk: clk_register: Correctly initialize enable_count Emilio López <emilio@elopez.com.ar> - 2016-02-10 04:20 +0100
    Re: [PATCH] clk: clk_register: Correctly initialize enable_count Rhyland Klein <rklein@nvidia.com> - 2016-02-10 19:40 +0100
      Re: [PATCH] clk: clk_register: Correctly initialize enable_count Michael Turquette <mturquette@baylibre.com> - 2016-02-11 22:40 +0100
        Re: [PATCH] clk: clk_register: Correctly initialize enable_count Rhyland Klein <rklein@nvidia.com> - 2016-02-11 23:00 +0100

csiph-web