Re: [PATCH v7 06/10] ppc64 ftrace: disable profiling for some functions

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 06/10] ppc64 ftrace: disable profiling for some functions
Date	2016-02-10 03:00 +0100
Message-ID	<r0set-3TU-1@gated-at.bofh.it> (permalink)
References	<qYuNt-4ix-19@gated-at.bofh.it> <qYuX9-4mU-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-01-25 at 16:31 +0100, Torsten Duwe wrote:

> At least POWER7/8 have MMUs that don't completely autoload;
> a normal, recoverable memory fault might pass through these functions.
> If a dynamic tracer function causes such a fault, any of these functions
> being traced with -mprofile-kernel may cause an endless recursion.

I'm not really happy with this one, still :)

At the moment I can trace these without any problems, with either ftrace or
kprobes, but obviously it was causing you some trouble. So I'd like to
understand why you were having issues when regular tracing doesn't.

If it's the case that tracing can work for these functions, but live patching
doesn't (for some reason), then maybe these should be blocked by the live
patching infrastructure rather than at the ftrace/kprobes level.

cheers

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 06/10] ppc64 ftrace: disable profiling for some  functions Michael Ellerman <mpe@ellerman.id.au> - 2016-02-10 03:00 +0100
  Re: [PATCH v7 06/10] ppc64 ftrace: disable profiling for some  functions Torsten Duwe <duwe@lst.de> - 2016-02-10 19:10 +0100

csiph-web