Re: [PATCH] SUNRPC: restore fair scheduling to priority queues.

From	NeilBrown <neilb@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] SUNRPC: restore fair scheduling to priority queues.
Date	2016-02-10 02:50 +0100
Message-ID	<r0s4O-3QG-9@gated-at.bofh.it> (permalink)
References	<qG7vY-2wd-17@gated-at.bofh.it> <qG8s1-37h-5@gated-at.bofh.it> <qGaNc-4Jx-9@gated-at.bofh.it> <qK7xn-830-5@gated-at.bofh.it> <r0rLs-3Iq-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Feb 10 2016, NeilBrown wrote:

> On Sun, Dec 27 2015, Trond Myklebust wrote:
>
>> On Tue, Dec 15, 2015 at 10:10 PM, NeilBrown <neilb@suse.com> wrote:
>>> If you treated all reads and writed the same, then I can't see value in
>>> restoring fair scheduling.   If there is any difference, then I suspect
>>> we do need the fairness.
>>
>> I disagree. Reclaiming memory should always be able to pre-empt
>> "interactive" features such as read. Everything goes down the toilet
>> when we force the kernel into situations where it needs to swap.
>
> That's your call I guess.  I certainly agree that memory-reclaim writes
> should get some priority (e.g. two writes serviced for every read).
> Whether they should be allowed to completely block reads I'm less sure
> of.  But it is probably purely academic as if the system is busy
> reclaiming you are unlikely to have any reads to want to send.
>
> My problem would be solved (I think) by treating reads and non-reclaim
> writes as equals.  I'll make a patch, see if I can test it, and let you
> know.

ahh.... I just discovered
Commit: b0ac1bd2bbfd ("NFS: Background flush should not be low priority")

I didn't notice that before.  I suspect that will fix the problem -
thanks.

I'll try testing and let you know if there is a problem.

Thanks,
NeilBrown

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] SUNRPC: restore fair scheduling to priority queues. NeilBrown <neilb@suse.com> - 2016-02-10 02:30 +0100
  Re: [PATCH] SUNRPC: restore fair scheduling to priority queues. NeilBrown <neilb@suse.com> - 2016-02-10 02:50 +0100

csiph-web