Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1330638
| From | Jani Nikula <jani.nikula@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/5] drm/i915: fix error path in intel_setup_gmbus() |
| Date | 2016-02-09 21:30 +0100 |
| Message-ID | <r0n58-Gp-13@gated-at.bofh.it> (permalink) |
| References | <r0mVr-wW-3@gated-at.bofh.it> <r0mVr-wW-1@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Tue, 09 Feb 2016, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> This fails to undo the setup for pin==0; moreover, something
> interesting happens if the setup failed already at pin==0.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/gpu/drm/i915/intel_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
> index 25254b5c1ac5..deb8282c26d8 100644
> --- a/drivers/gpu/drm/i915/intel_i2c.c
> +++ b/drivers/gpu/drm/i915/intel_i2c.c
> @@ -683,7 +683,7 @@ int intel_setup_gmbus(struct drm_device *dev)
> return 0;
>
> err:
> - while (--pin) {
> + while (pin--) {
> if (!intel_gmbus_is_valid_pin(dev_priv, pin))
> continue;
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Fixes: f899fc64cda8 ("drm/i915: use GMBUS to manage i2c links")
Cc: stable@vger.kernel.org
--
Jani Nikula, Intel Open Source Technology Center
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/5] drm/i915: fix error path in intel_setup_gmbus() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-02-09 21:20 +0100
Re: [PATCH 2/5] drm/i915: fix error path in intel_setup_gmbus() Jani Nikula <jani.nikula@linux.intel.com> - 2016-02-09 21:30 +0100
Re: [PATCH 2/5] drm/i915: fix error path in intel_setup_gmbus() Jani Nikula <jani.nikula@linux.intel.com> - 2016-02-10 10:00 +0100
csiph-web