[PATCH v2 8/8] MIPS: OCTEON: Simplify code in octeon_irq_ciu_gpio_set_type()

From	David Daney <ddaney.cavm@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 8/8] MIPS: OCTEON: Simplify code in octeon_irq_ciu_gpio_set_type()
Date	2016-02-09 20:10 +0100
Message-ID	<r0lPJ-8iJ-35@gated-at.bofh.it> (permalink)
References	<r0lPI-8iJ-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: David Daney <david.daney@cavium.com>

Use the trigger type passed in to the function instead of reading it
back out of the irq_data.

Signed-off-by: David Daney <david.daney@cavium.com>
---
 arch/mips/cavium-octeon/octeon-irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
index 9b6a65b..368eb49 100644
--- a/arch/mips/cavium-octeon/octeon-irq.c
+++ b/arch/mips/cavium-octeon/octeon-irq.c
@@ -713,7 +713,7 @@ static int octeon_irq_ciu_gpio_set_type(struct irq_data *data, unsigned int t)
 	irqd_set_trigger_type(data, t);
 	octeon_irq_gpio_setup(data);
 
-	if (irqd_get_trigger_type(data) & IRQ_TYPE_EDGE_BOTH)
+	if (t & IRQ_TYPE_EDGE_BOTH)
 		irq_set_handler_locked(data, handle_edge_irq);
 	else
 		irq_set_handler_locked(data, handle_level_irq);
-- 
1.7.11.7

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 8/8] MIPS: OCTEON: Simplify code in octeon_irq_ciu_gpio_set_type() David Daney <ddaney.cavm@gmail.com> - 2016-02-09 20:10 +0100

csiph-web