Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1330344

[PATCH 2/3] net: arc_emac: reset txbd_curr and txbd_dirty pointers to zero

Path csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From Alexander Kochetkov <al.kochet@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/3] net: arc_emac: reset txbd_curr and txbd_dirty pointers to zero
Date Tue, 09 Feb 2016 16:30:02 +0100
Message-ID <r0ioO-5QL-25@gated-at.bofh.it> (permalink)
References <r0ioN-5QL-3@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=e0H9uwhV9VZ3CopwtHgKCLjQrHaQoA9v6EAwNQP+5Yw=; b=E6quruWV7Tb15SV7ECP+oYNyqtHxJZJ5V73najCs0NQB8PSTya+Pk/HqClkKwEZnBM tQI1pxRlrx4gOa9duiZ2F4GtUSU2lAGnAJ/lstDHRHDCDfkVJ26+Nfxilo6E4RsJgU0+ kUM+TFUYIEE520lwcAz2d2bdOSrITZom2SZw2YGjgIH+JKlWFs87lINJvhRwUBDlmOFf KBBj7TeHoi94hPHhe6Bjdx5XwKAWPJkMxMJMzji7XuFzA3rxJhGhPgrP+dsPKnhdoFzH JeM9+qzsUK2VQkoT20ISXHWaEH2ocxvsPhNNOXMKO5aRzxi00DRDkEVBjTydLg9gDxM0 N6vQ==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=e0H9uwhV9VZ3CopwtHgKCLjQrHaQoA9v6EAwNQP+5Yw=; b=VSK+0DUNKqN19cvGnJjOR6R9AG+JM4+AeQDBoitAQgLoJo1IyvTxnV5DJPdnb4mLOG 1qWOb2d2HZvYVpTlGW7jHhNhaKJFEahrpzOBD1WnrxxO1qGMyzsFpY5mBZBTK2kBmf5O dwzFbU8Ygkua872gtHo4RcGpyD4sZX533V5fmwRb6ui4nqm3oEzla3Z5R1p5v0av2w8H 44EpJMlxvzubJz9PFugw7xxOgOLPzOn/AP8YPRdtrdqmRwOFAn2AMJK6G8lVOOk8PnD4 YUCvlQO2GDmAyGztOCiLJARA3ZQXGvNb4aVusEGUWv3y0rYnQJn/iJDRSAn4UhLP8wAB LDqw==
X-Gm-Message-State AG10YOSaQ/CKTaJpgQaEnHIvooYAuJtmjAz+TT/O66F3oL5Qq6ivX1u0EU6bjSPlOg7HAw==
X-Received by 10.112.172.200 with SMTP id be8mr13637879lbc.78.1455031268459; Tue, 09 Feb 2016 07:21:08 -0800 (PST)
X-Mailer git-send-email 1.7.9.5
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 32
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org, "'David S. Miller'" <davem@davemloft.net>, Alexander Kochetkov <al.kochet@gmail.com>
X-Original-Date Tue, 9 Feb 2016 18:20:39 +0300
X-Original-Message-ID <1455031240-29385-3-git-send-email-al.kochet@gmail.com>
X-Original-References <1455031240-29385-1-git-send-email-al.kochet@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1330344

Show key headers only | View raw


EMAC reset internal tx ring pointer to zero at statup.
txbd_curr and txbd_dirty can be different from zero.
That cause ethernet transfer hang (no packets transmitted).

In order to reproduce, run on device:
    ifconfig eth0 down
    ifconfig eth0 up

Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>

---
CC: stable@vger.kernel.org # 3.18.x-
---
 drivers/net/ethernet/arc/emac_main.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c
index 63a63e3..4f6e5be 100644
--- a/drivers/net/ethernet/arc/emac_main.c
+++ b/drivers/net/ethernet/arc/emac_main.c
@@ -447,6 +447,9 @@ static int arc_emac_open(struct net_device *ndev)
 		*last_rx_bd = (*last_rx_bd + 1) % RX_BD_NUM;
 	}
 
+	priv->txbd_curr = 0;
+	priv->txbd_dirty = 0;
+
 	/* Clean Tx BD's */
 	memset(priv->txbd, 0, TX_RING_SZ);
 
-- 
1.7.9.5

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 2/3] net: arc_emac: reset txbd_curr and txbd_dirty pointers to zero Alexander Kochetkov <al.kochet@gmail.com> - 2016-02-09 16:30 +0100

csiph-web