Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1330258

Re: [PATCH] x86/head64: use pointer type in sizeof

Show all headers | View raw

* Alexander Kuleshov <kuleshovmail@gmail.com> wrote:

> We changed loops with memset in the 5e9ebbd87a99 commit (x86/boot:
> Micro-optimize reset_early_page_tables()). The base for size of
> memset was size of pud_p/pmd_p, but the they are actually
> represented as pointers, although they have the same sizes.

That's rather confused. Also the title is confused:

  x86/head64: use pointer type in sizeof

what the fix does it to _not_ use a pointer type.

I fixed the title and the changelog, but you really need to be more careful...

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/head64: use pointer type in sizeof Alexander Kuleshov <kuleshovmail@gmail.com> - 2016-02-09 14:50 +0100
  Re: [PATCH] x86/head64: use pointer type in sizeof Ingo Molnar <mingo@kernel.org> - 2016-02-09 15:00 +0100
  [tip:x86/boot] x86/boot: Use proper array element type in memset(  ) size calculation tip-bot for Alexander Kuleshov <tipbot@zytor.com> - 2016-02-09 17:20 +0100

csiph-web