Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1330249

Re: [PATCH] drm/tegra: remove unused variable

Show all headers | View raw

On Tue, Feb 09, 2016 at 01:28:15PM +0100, Arnd Bergmann wrote:
> A newly merged patch removed the only user of this variable,
> leading to a harmless gcc warning:
> 
> drivers/gpu/drm/tegra/drm.c: In function 'tegra_drm_preclose':
> drivers/gpu/drm/tegra/drm.c:861:19: error: unused variable 'crtc' [-Werror=unused-variable]
> 
> This removes the variable as well.
> 
> Cc: Terje Bergström <tbergstrom@nvidia.com>
> Cc: Daniel Stone <daniels@collabora.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Fixes: 0417d424ac0d ("drm/tegra: Stop cancelling page flip events")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Already fixed by Dave in 10c1b6183a163aca59ba92b88f2b4c4cecd20d4c. Thanks
anyway for the quick patch.
-Daniel

> ---
>  drivers/gpu/drm/tegra/drm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
> index 021d0e1398fb..8e6b18caa706 100644
> --- a/drivers/gpu/drm/tegra/drm.c
> +++ b/drivers/gpu/drm/tegra/drm.c
> @@ -858,7 +858,6 @@ static void tegra_drm_preclose(struct drm_device *drm, struct drm_file *file)
>  {
>  	struct tegra_drm_file *fpriv = file->driver_priv;
>  	struct tegra_drm_context *context, *tmp;
> -	struct drm_crtc *crtc;
>  
>  	list_for_each_entry_safe(context, tmp, &fpriv->contexts, list)
>  		tegra_drm_context_free(context);
> -- 
> 2.7.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/tegra: remove unused variable Arnd Bergmann <arnd@arndb.de> - 2016-02-09 13:30 +0100
  Re: [PATCH] drm/tegra: remove unused variable Daniel Vetter <daniel@ffwll.ch> - 2016-02-09 15:00 +0100

csiph-web