Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1330242

Re: [PATCH v2 20/22] media: au0828 add enable, disable source handlers

From Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 20/22] media: au0828 add enable, disable source handlers
Date 2016-02-09 14:50 +0100
Message-ID <r0gQ2-4IO-21@gated-at.bofh.it> (permalink)
References <qYjoZ-3uR-3@gated-at.bofh.it> <qYjoZ-3uR-1@gated-at.bofh.it> <qYpkK-7ir-13@gated-at.bofh.it> <r02N4-39K-19@gated-at.bofh.it> <r036p-3wa-5@gated-at.bofh.it>
Organization Samsung

Show all headers | View raw

Em Mon, 08 Feb 2016 16:00:26 -0700
Shuah Khan <shuahkh@osg.samsung.com> escreveu:

> >>> +	ret = __media_entity_pipeline_start(entity, pipe);
> >>> +	if (ret) {
> >>> +		pr_err("Start Pipeline: %s->%s Error %d\n",
> >>> +			source->name, entity->name, ret);
> >>> +		ret = __media_entity_setup_link(found_link, 0);
> >>> +		pr_err("Deactive link Error %d\n", ret);
> >>> +		goto end;
> >>> +	}  
> >>
> >> Hmm... isn't it to early to activate the pipeline here? My original
> >> guess is that, on the analog side, this should happen only at the stream
> >> on code. Wouldn't this break apps like mythTV?  
> 
> On analog side, there are a few ioctls that
> change the configuration on the tuner way
> before stream on step. Is there a reason to
> separate the setup_link() and pipeline_start()
> steps? I can separate these two steps, but I
> am not really seeing the reason for that.

I'm actually ok with that, provided that it won't break existing
apps. Did you test it with MythTV?

Regards,
Mauro

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 20/22] media: au0828 add enable, disable source handlers Shuah Khan <shuahkh@osg.samsung.com> - 2016-02-04 05:10 +0100
  Re: [PATCH v2 20/22] media: au0828 add enable, disable source  handlers Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-02-04 11:30 +0100
    Re: [PATCH v2 20/22] media: au0828 add enable, disable source  handlers Shuah Khan <shuahkh@osg.samsung.com> - 2016-02-08 23:50 +0100
      Re: [PATCH v2 20/22] media: au0828 add enable, disable source  handlers Shuah Khan <shuahkh@osg.samsung.com> - 2016-02-09 00:10 +0100
        Re: [PATCH v2 20/22] media: au0828 add enable, disable source  handlers Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-02-09 14:50 +0100
      Re: [PATCH v2 20/22] media: au0828 add enable, disable source  handlers Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-02-09 12:00 +0100

csiph-web