Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1330104

Re: [PATCH] ARM: ks8695: fix __initdata annotation

Show all headers | View raw

On Tuesday 09 February 2016 10:00:30 Uwe Kleine-König wrote:
> > diff --git a/arch/arm/mach-ks8695/board-og.c b/arch/arm/mach-ks8695/board-og.c
> > index 1f4f2f4f25bb..fa1a7c2ca2bb 100644
> > --- a/arch/arm/mach-ks8695/board-og.c
> > +++ b/arch/arm/mach-ks8695/board-og.c
> > @@ -80,7 +80,7 @@ static void __init og_pci_bus_reset(void)
> >  #define      S8250_VIRT      0xf4000000
> >  #define      S8250_SIZE      0x00100000
> >  
> > -static struct __initdata map_desc og_io_desc[] = {
> > +static struct map_desc __initdata og_io_desc[] = {
> 
> I would have expected that
> 
> +static struct map_desc og_io_desc[] __initdata = {
> 
> is the correct variant?
> 

I think those two mean the exact same thing, and we have tons of examples
for either one in the kernel, unlike the one I removed. I have
verified that the resulting object files are identical.

Can you point me to some documentation that clarifies which one to use,
and why?

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: ks8695: fix __initdata annotation Arnd Bergmann <arnd@arndb.de> - 2016-02-08 15:30 +0100
  Re: [PATCH] ARM: ks8695: fix __initdata annotation Greg Ungerer <gerg@uclinux.org> - 2016-02-09 00:40 +0100
  Re: [PATCH] ARM: ks8695: fix __initdata annotation Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-09 10:10 +0100
    Re: [PATCH] ARM: ks8695: fix __initdata annotation Arnd Bergmann <arnd@arndb.de> - 2016-02-09 12:20 +0100
      Re: [PATCH] ARM: ks8695: fix __initdata annotation Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-09 12:40 +0100
        Re: [PATCH] ARM: ks8695: fix __initdata annotation Arnd Bergmann <arnd@arndb.de> - 2016-02-09 16:20 +0100

csiph-web