Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1329964

Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a separate module

From Pali Rohár <pali.rohar@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a separate module
Date 2016-02-09 09:40 +0100
Message-ID <r0c01-1wH-5@gated-at.bofh.it> (permalink)
References (4 earlier) <qTiWC-2IG-7@gated-at.bofh.it> <qTn9U-5Gc-7@gated-at.bofh.it> <qTnjz-5JB-1@gated-at.bofh.it> <qTnCV-5S1-3@gated-at.bofh.it> <r01R2-2zw-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Monday 08 February 2016 13:42:10 Darren Hart wrote:
> Assuming the above is an accurate view, I don't see any reason to go beyond the
> minimal change to the existing SMBIOS code to make it a usable API. If the need
> arises, we can always make such optimizations and performance improvements
> later. This is an internal API and we can change it whenever we need to so long
> as we update the call sites.

Problem is that now smbios code from dell-laptop.c is moved into
dell-smbios.c and dell-smbios.h and LED subsystem starts using
dell-smbios.h. In this case I'm thinking that we have something like API
usable by other modules/subsystem. And I'm thinking if it is not better
to create "correct" API now instead rewriting code in LED and platform
subsystem again later... As this API needs to provide just 1 function,
send command to Dell SMBIOS I think that API is still minimal. Currently
we have another two functions alloc/free buffer (needed for send).

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a  separate module Darren Hart <dvhart@infradead.org> - 2016-02-08 22:50 +0100
  Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a  separate module Pali Rohár <pali.rohar@gmail.com> - 2016-02-09 09:40 +0100
    Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a  separate module Michał Kępień <kernel@kempniu.pl> - 2016-02-09 15:00 +0100
    Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a  separate module Darren Hart <dvhart@infradead.org> - 2016-02-09 18:00 +0100
      Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a separate module Pali Rohár <pali.rohar@gmail.com> - 2016-02-09 20:20 +0100
        Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a  separate module Darren Hart <dvhart@infradead.org> - 2016-02-11 00:10 +0100

csiph-web