Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331936

Re: [PATCH v2] pinctrl: sunxi: H3 requires irq_read_needs_mux

Show all headers | View raw

On Fri, Feb 5, 2016 at 2:51 PM, Chen-Yu Tsai <wens@csie.org> wrote:
> On Fri, Feb 5, 2016 at 9:39 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Wed, Feb 3, 2016 at 8:57 AM, Krzysztof Adamski <k@japko.eu> wrote:
>>
>>> It seems that on H3, just like on A10, when GPIOs are configured as
>>> external interrupt data registers does not contain their value.  When
>>> value is read, GPIO function must be temporary switched to input for
>>> reads.
>>>
>>> Signed-off-by: Krzysztof Adamski <k@japko.eu>
>>
>> 1. Waiting for Maxime's ACK on this patch.
>
> Maxime already acked v1.
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
>
>> 2. Is this a regression that need to go in to fixes?
>
> This driver was introduced in 4.5-rc1. It'd be nice if this fix could make
> it in 4.5. :)

OK ooops merged the v1 version, undoing and merging this version
instead.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] pinctrl: sunxi: H3 requires irq_read_needs_mux Linus Walleij <linus.walleij@linaro.org> - 2016-02-11 14:30 +0100

csiph-web