Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331945

Re: [PATCH v4 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set

Show all headers | View raw

On Tue, Feb 9, 2016 at 3:58 PM, Krzysztof Adamski
<krzysztof.adamski@tieto.com> wrote:

> sunxi_pmx_set accepts pin number and then calculates offset by
> subtracting pin_base from it. sunxi_pinctrl_gpio_get, on the other hand,
> gets offset so we have to convert it to pin number so we won't get
> negative value in sunxi_pmx_set.
>
> This was only used on A10 so far, where there is only one GPIO chip with
> pin_base set to 0 so it didn't matter. However H3 also requires this
> workaround but have two pinmux sections, triggering problem for PL port.
>
> Signed-off-by: Krzysztof Adamski <k@japko.eu>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

OK applied this version that has Maxime's ACK.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/5] pinctrl: sunxi: Add H3 R_PIO controller support Krzysztof Adamski <krzysztof.adamski@tieto.com> - 2016-02-09 16:00 +0100
  [PATCH v4 3/5] pinctrl: sunxi: Add H3 R_PIO controller support Krzysztof Adamski <krzysztof.adamski@tieto.com> - 2016-02-09 16:10 +0100
  [PATCH v4 2/5] dts: sun8i-h3: Add APB0 related clocks and resets Krzysztof Adamski <krzysztof.adamski@tieto.com> - 2016-02-09 16:10 +0100
  [PATCH v4 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set Krzysztof Adamski <krzysztof.adamski@tieto.com> - 2016-02-09 16:10 +0100
    Re: [PATCH v4 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set Linus Walleij <linus.walleij@linaro.org> - 2016-02-11 14:40 +0100
  [PATCH v4 1/5] clk: sunxi: Add apb0 gates for H3 Krzysztof Adamski <krzysztof.adamski@tieto.com> - 2016-02-09 16:10 +0100

csiph-web