Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331838

Re: [PATCH] PM / OPP: Fix NULL pointer dereference crash when disabling OPPs

Show all headers | View raw

On 11-02-16, 11:25, Jon Hunter wrote:
> Commit 7d34d56ef334 ("PM / OPP: Disable OPPs that aren't supported by
> the regulator") disables OPPs that are not supported by the regulator.
> This is causes a crash on Tegra124 Jetson TK1 when using the DFLL clock
> source for the CPU. The DFLL manages the voltage itself and so there is
> no regulator specified for the OPPs and so we get a crash when we try to
> dereference the regulator pointer. Fix this by checking to see if the
> regulator IS_ERR_OR_NULL before dereferencing it.
> 
> Fixes: 7d34d56ef334 ("PM / OPP: Disable OPPs that aren't supported by the
> regulator")
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  drivers/base/power/opp/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Sorry about that :(

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] PM / OPP: Fix NULL pointer dereference crash when disabling OPPs Jon Hunter <jonathanh@nvidia.com> - 2016-02-11 12:30 +0100
  Re: [PATCH] PM / OPP: Fix NULL pointer dereference crash when  disabling OPPs Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-11 12:40 +0100
    Re: [PATCH] PM / OPP: Fix NULL pointer dereference crash when  disabling OPPs "Rafael J. Wysocki" <rafael@kernel.org> - 2016-02-11 22:20 +0100

csiph-web