Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331816

Re: [PATCH] drm/msm: remove unused variable

Show all headers | View raw

On Thu, Feb 11, 2016 at 10:10:00AM +0100, Arnd Bergmann wrote:
> After the drm_device_is_unplugged() was removed, the 'dev' variable is now
> unused, and we get a warning for that:
> 
> drivers/gpu/drm/msm/msm_fbdev.c: In function 'msm_fbdev_mmap':
> drivers/gpu/drm/msm/msm_fbdev.c:65:21: error: unused variable 'dev' [-Werror=unused-variable]
> 
> This removes the variable as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: e9f8250f2f92 ("drm/msm: remove the drm_device_is_unplugged check")

Applied, thanks.
-Daniel

> ---
>  drivers/gpu/drm/msm/msm_fbdev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
> index e119c2979509..d9759bf3482e 100644
> --- a/drivers/gpu/drm/msm/msm_fbdev.c
> +++ b/drivers/gpu/drm/msm/msm_fbdev.c
> @@ -62,7 +62,6 @@ static int msm_fbdev_mmap(struct fb_info *info, struct vm_area_struct *vma)
>  	struct drm_fb_helper *helper = (struct drm_fb_helper *)info->par;
>  	struct msm_fbdev *fbdev = to_msm_fbdev(helper);
>  	struct drm_gem_object *drm_obj = fbdev->bo;
> -	struct drm_device *dev = helper->dev;
>  	int ret = 0;
>  
>  	ret = drm_gem_mmap_obj(drm_obj, drm_obj->size, vma);
> -- 
> 2.7.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/msm: remove unused variable Arnd Bergmann <arnd@arndb.de> - 2016-02-11 10:20 +0100
  Re: [PATCH] drm/msm: remove unused variable Daniel Vetter <daniel@ffwll.ch> - 2016-02-11 11:50 +0100

csiph-web