Re: [RFC][PATCH v3 1/4] printk: move can_use_console out of console_trylock_for_printk

From	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH v3 1/4] printk: move can_use_console out of console_trylock_for_printk
Date	2016-02-11 09:10 +0100
Message-ID	<r0Uu6-65R-5@gated-at.bofh.it> (permalink)
References	<qU1Al-8nr-3@gated-at.bofh.it> <qU1Am-8nr-19@gated-at.bofh.it> <r0G7M-4Gb-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Petr,

On (02/10/16 17:48), Petr Mladek wrote:
[..]
> I would personally remove console_trylock_for_printk() already in this
> patch. I mean to fold the 3rd patch into this one.

will do.

> >  int printk_delay_msec __read_mostly;
> 
> > @@ -2247,9 +2233,21 @@ void console_unlock(void)
> >  	do_cond_resched = console_may_schedule;
> >  	console_may_schedule = 0;
> >  
> > +again:
> > +	/*
> > +	 * We released the console_sem lock, so we need to recheck if
> > +	 * cpu is online and (if not) is there at least one CON_ANYTIME
> > +	 * console.
> > +	 */
> > +	if (!can_use_console()) {
> > +		console_locked = 0;
> > +		up_console_sem();
> > +		return;
> > +	}
> 
> This is a bug fix and a nice clean up together.
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>

thanks.

	-ss

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC][PATCH v3 1/4] printk: move can_use_console out of  console_trylock_for_printk Petr Mladek <pmladek@suse.com> - 2016-02-10 17:50 +0100
  Re: [RFC][PATCH v3 1/4] printk: move can_use_console out of  console_trylock_for_printk Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-02-11 09:10 +0100

csiph-web