Re: [PATCH V4 12/23] x86, ia64, pci: Remove ACPI companion device from platform specific data.

From	Tomasz Nowicki <tn@semihalf.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4 12/23] x86, ia64, pci: Remove ACPI companion device from platform specific data.
Date	2016-02-10 22:30 +0100
Message-ID	<r0KuK-7H1-21@gated-at.bofh.it> (permalink)
References	<qYvTc-53o-7@gated-at.bofh.it> <qYvTd-53o-21@gated-at.bofh.it> <r0kgV-7eu-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/09/2016 06:28 PM, Lorenzo Pieralisi wrote:
> This patch has to be squashed with the previous one otherwise it
> has bisectability issues (ie the previous patch passes the parent
> to the pci_create_root_bus() call so, without this patch applied,
> the companion initialization would fail).
I do not think so. The previous patch passes the parent to the 
pci_create_root_bus(), indeed, so pci_create_root_bus() set companion 
device before calling pcibios_root_bridge_prepare() (for both cases x86 
and ia64). In turn, pcibios_root_bridge_prepare() will do nothing, since 
bridge->dev.parent != NULL. After all, pcibios_root_bridge_prepare() is 
dead code.
>
> Other than that:
>
> Reviewed-by: Lorenzo Pieralisi<lorenzo.pieralisi@arm.com>
Thanks!

Tomasz

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V4 12/23] x86, ia64, pci: Remove ACPI companion device  from platform specific data. Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-02-09 18:30 +0100
  Re: [PATCH V4 12/23] x86, ia64, pci: Remove ACPI companion device  from platform specific data. Tomasz Nowicki <tn@semihalf.com> - 2016-02-10 22:30 +0100

csiph-web