Re: [PATCH v6 4/7] clk: mediatek: Add MT2701 clock support

From	Michael Turquette <mturquette@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 4/7] clk: mediatek: Add MT2701 clock support
Date	2016-02-10 21:10 +0100
Message-ID	<r0Jfl-6ZA-27@gated-at.bofh.it> (permalink)
References	<qYL1T-6Q8-5@gated-at.bofh.it> <qYLbA-6TD-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Quoting James Liao (2016-02-05 01:37:27)
> +CLK_OF_DECLARE(mtk_topckgen, "mediatek,mt2701-topckgen", mtk_topckgen_init);
> +CLK_OF_DECLARE(mtk_infrasys, "mediatek,mt2701-infracfg", mtk_infrasys_init);
> +CLK_OF_DECLARE(mtk_pericfg, "mediatek,mt2701-pericfg", mtk_pericfg_init);
> +CLK_OF_DECLARE(mtk_mmsys, "mediatek,mt2701-mmsys", mtk_mmsys_init);
> +CLK_OF_DECLARE(mtk_imgsys, "mediatek,mt2701-imgsys", mtk_imgsys_init);
> +CLK_OF_DECLARE(mtk_vdecsys, "mediatek,mt2701-vdecsys", mtk_vdecsys_init);
> +CLK_OF_DECLARE(mtk_hifsys, "mediatek,mt2701-hifsys", mtk_hifsys_init);
> +CLK_OF_DECLARE(mtk_ethsys, "mediatek,mt2701-ethsys", mtk_ethsys_init);
> +CLK_OF_DECLARE(mtk_bdpsys, "mediatek,mt2701-bdpsys", mtk_bdpsys_init);
> +CLK_OF_DECLARE(mtk_apmixedsys, "mediatek,mt2701-apmixedsys",

:-/

This is way too much CLK_OF_DECLARE and not enough Linux Driver Model.

I understand that some platforms really must initialize some clocks very
early, but can we please separate those into one table and call
CLK_OF_DECLARE on only that set, and then register the rest through a
platform_driver later on?

Best regards,
Mike

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 4/7] clk: mediatek: Add MT2701 clock support Michael Turquette <mturquette@baylibre.com> - 2016-02-10 21:10 +0100
  Re: [PATCH v6 4/7] clk: mediatek: Add MT2701 clock support James Liao <jamesjj.liao@mediatek.com> - 2016-02-15 10:30 +0100

csiph-web