Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1331436
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header |
| Date | 2016-02-10 20:00 +0100 |
| Message-ID | <r0I9A-65O-3@gated-at.bofh.it> (permalink) |
| References | <r0pqi-251-23@gated-at.bofh.it> <r0pqj-251-35@gated-at.bofh.it> <r0G7M-4Gb-25@gated-at.bofh.it> <r0HZU-62x-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Feb 11, 2016 at 01:42:52AM +0700, Suravee Suthikulpanit wrote:
> The reason I picked this location to place the header file is because
> there is already an existing include/linux/perf/arm_pmu.h file there.
I don't think anything arch-specific belongs in generic kernel header
paths.
> So, I thought it might be alright to put the perf_event_amd_iommu.h
> here.
>
> Having the information in the file arch/x86/events/amd/iommu.h seems
> strange for having to specify ../../arch/x86/events/amd/iommu.h in the
> IOMMU driver.
>
> So, you think it would be alright if move
>
> include/linux/perf/perf_event_amd_iommu.h
> to
> arch/x86/include/perf/perf_event_amd_iommu.h
If it feels strange to you, you can move it to arch/x86/include/asm/
There we put the arch-specific stuff.
Then you can do
#include <asm/perf/amd/iommu.h>
or so. I've moved it to arch/x86/events/amd/iommu.h already anyway.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> - 2016-02-10 00:00 +0100
Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Borislav Petkov <bp@alien8.de> - 2016-02-10 17:50 +0100
Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> - 2016-02-10 19:50 +0100
Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Borislav Petkov <bp@alien8.de> - 2016-02-10 20:00 +0100
Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> - 2016-02-10 20:00 +0100
Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Borislav Petkov <bp@alien8.de> - 2016-02-10 20:10 +0100
csiph-web