Re: [PATCH v5 RESEND 2/5] ARM: sa1111: ensure no negative value gets returned on positive match

From	Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 RESEND 2/5] ARM: sa1111: ensure no negative value gets returned on positive match
Date	2016-02-10 17:50 +0100
Message-ID	<r0G7M-4Gb-23@gated-at.bofh.it> (permalink)
References	<r0Avn-12b-5@gated-at.bofh.it> <r0Avo-12b-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10 February 2016 at 11:47, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> This patch ensures that existing bus match callbacks don't return
> negative values (which might be interpreted as potential errors in the
> future) in case of positive match.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

FYI:
This one has actually been acked by Russell.
https://lkml.org/lkml/2015/12/23/111

Kind regards
Uffe

> ---
>  arch/arm/common/sa1111.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c
> index 3d22494..fb0a0a4 100644
> --- a/arch/arm/common/sa1111.c
> +++ b/arch/arm/common/sa1111.c
> @@ -1290,7 +1290,7 @@ static int sa1111_match(struct device *_dev, struct device_driver *_drv)
>         struct sa1111_dev *dev = SA1111_DEV(_dev);
>         struct sa1111_driver *drv = SA1111_DRV(_drv);
>
> -       return dev->devid & drv->devid;
> +       return !!(dev->devid & drv->devid);
>  }
>
>  static int sa1111_bus_suspend(struct device *dev, pm_message_t state)
> --
> 1.9.2
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 RESEND 0/5] AMBA: add complete support for power domains Marek Szyprowski <m.szyprowski@samsung.com> - 2016-02-10 11:50 +0100
  [PATCH v5 RESEND 1/5] drivers: nvdimm: ensure no negative value gets  returned on positive match Marek Szyprowski <m.szyprowski@samsung.com> - 2016-02-10 11:50 +0100
  [PATCH v5 RESEND 3/5] driver core: handle -EPROBE_DEFER from  bus_type.match() Marek Szyprowski <m.szyprowski@samsung.com> - 2016-02-10 11:50 +0100
    Re: [PATCH v5 RESEND 3/5] driver core: handle -EPROBE_DEFER from  bus_type.match() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-12 04:20 +0100
  [PATCH v5 RESEND 5/5] ARM: amba: Properly handle devices with power  domains Marek Szyprowski <m.szyprowski@samsung.com> - 2016-02-10 11:50 +0100
  [PATCH v5 RESEND 2/5] ARM: sa1111: ensure no negative value gets  returned on positive match Marek Szyprowski <m.szyprowski@samsung.com> - 2016-02-10 11:50 +0100
    Re: [PATCH v5 RESEND 2/5] ARM: sa1111: ensure no negative value gets  returned on positive match Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-10 17:50 +0100

csiph-web