Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1331240

[PATCH v3 3/6] irqchip: irq-armada-370-xp: use PCI_MSI_DOORBELL_START where appropriate

From Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Newsgroups linux.kernel
Subject [PATCH v3 3/6] irqchip: irq-armada-370-xp: use PCI_MSI_DOORBELL_START where appropriate
Date 2016-02-10 15:50 +0100
Message-ID <r0EfF-3qm-49@gated-at.bofh.it> (permalink)
References <r0EfD-3qm-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


As suggested by Gregory Clement, this commit adjusts the
irq-armada-370-xp driver to use the PCI_MSI_DOORBELL_START define in
the armada_370_xp_handle_msi_irq() function, rather than hardcoding
its value.

Suggested-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
 drivers/irqchip/irq-armada-370-xp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
index e5738c5..f53eb71 100644
--- a/drivers/irqchip/irq-armada-370-xp.c
+++ b/drivers/irqchip/irq-armada-370-xp.c
@@ -401,10 +401,10 @@ static void armada_370_xp_handle_msi_irq(struct pt_regs *regs, bool is_chained)
 
 		if (is_chained) {
 			irq = irq_find_mapping(armada_370_xp_msi_inner_domain,
-					       msinr - 16);
+					       msinr - PCI_MSI_DOORBELL_START);
 			generic_handle_irq(irq);
 		} else {
-			irq = msinr - 16;
+			irq = msinr - PCI_MSI_DOORBELL_START;
 			handle_domain_irq(armada_370_xp_msi_inner_domain,
 					  irq, regs);
 		}
-- 
2.6.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 0/6] irqchip: irq-armada-370-xp: generic MSI infrastructure and assorted fixes Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-02-10 15:50 +0100
  [PATCH v3 1/6] irqchip: irq-armada-370-xp: add Kconfig option for the driver Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-02-10 15:50 +0100
  [PATCH v3 6/6] ARM: mvebu: use the ARMADA_370_XP_IRQ option Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-02-10 15:50 +0100
  [PATCH v3 3/6] irqchip: irq-armada-370-xp: use PCI_MSI_DOORBELL_START where appropriate Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-02-10 15:50 +0100
  [PATCH v3 2/6] irqchip: irq-armada-370-xp: use the generic MSI infrastructure Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-02-10 15:50 +0100
  Re: [PATCH v3 0/6] irqchip: irq-armada-370-xp: generic MSI  infrastructure and assorted fixes Jason Cooper <jason@lakedaemon.net> - 2016-02-16 18:50 +0100
    Re: [PATCH v3 0/6] irqchip: irq-armada-370-xp: generic MSI  infrastructure and assorted fixes Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-02-16 21:10 +0100

csiph-web