Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331175

Re: [tip:x86/mm] x86/mm: Add INVPCID helpers

Show all headers | View raw

Hi,

On Wed, 10 Feb 2016, Borislav Petkov wrote:

> --- a/arch/x86/include/asm/tlbflush.h
> +++ b/arch/x86/include/asm/tlbflush.h
> @@ -23,7 +23,7 @@ static inline void __invpcid(unsigned long pcid, unsigned long addr,
>  	 * invpcid (%rcx), %rax in long mode.
>  	 */
>  	asm volatile (".byte 0x66, 0x0f, 0x38, 0x82, 0x01"
> -		      : : "m" (desc), "a" (type), "c" (desc) : "memory");
> +		      : : "m" (*desc), "a" (type), "c" (desc) : "memory");

That still doesn't do what you want.  Arrays in C are funny.  *desc is 
exactly equivalent to desc[0], _not_ to the whole array, indeed there's no 
C syntax to name an lvalue of array type in normal expressions.  You need 
to jump through hoops for this:

  "m" (*(struct {unsigned long x[2];} *)desc)

It'd probably be easier to simply declare the descriptor as a struct, 
rather than an array, then the original syntax would have been mostly 
correct:

  struct {u64 d[2];} desc = { pcid, addr };
  asm ... "m" (desc), "c" (&desc)


Ciao,
Michael.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[tip:x86/mm] x86/mm: Add INVPCID helpers tip-bot for Andy Lutomirski <tipbot@zytor.com> - 2016-02-09 17:10 +0100
  Re: [tip:x86/mm] x86/mm: Add INVPCID helpers Borislav Petkov <bp@alien8.de> - 2016-02-10 13:10 +0100
    Re: [tip:x86/mm] x86/mm: Add INVPCID helpers Michael Matz <matz@suse.de> - 2016-02-10 14:50 +0100
      [PATCH -v1.1] x86/mm: Fix INVPCID asm constraint Borislav Petkov <bp@alien8.de> - 2016-02-10 16:00 +0100
        Re: [PATCH -v1.1] x86/mm: Fix INVPCID asm constraint Andy Lutomirski <luto@amacapital.net> - 2016-02-11 03:50 +0100

csiph-web