Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code

From	Greg Kurz <gkurz@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code
Date	2016-02-10 14:50 +0100
Message-ID	<r0Djz-2QB-11@gated-at.bofh.it> (permalink)
References	<qQx5M-2Pq-9@gated-at.bofh.it> <qQx5O-2Pq-43@gated-at.bofh.it> <r0Brs-1FM-3@gated-at.bofh.it> <r0CGT-2BB-15@gated-at.bofh.it> <r0D0e-2IY-1@gated-at.bofh.it>
Organization	IBM

Show all headers | View raw

On Wed, 10 Feb 2016 14:23:33 +0100
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:

> On Wed, 10 Feb 2016 14:08:43 +0100
> Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
> 
> > But you are right, there is a bug: we should rollback if vhost_init_used()
> > fails. Something like below:
> > 
> >  err_used:
> >         vq->private_data = oldsock;
> >         vhost_net_enable_vq(n, vq);
> > +       vhost_adjust_vring_endian(vq);  
> 
> Shouldn't we switch back before we reenable? Or have I lost myself in
> this maze here again?
> 

I haven't spotted any path under vhost_net_enable_vq() that needs
the vring endianness, but indeed it looks safer to switch back
before a worker thread may be woken up.

> >         if (ubufs)
> >                 vhost_net_ubuf_put_wait_and_free(ubufs);
> >  err_ubufs:

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the  core code "Michael S. Tsirkin" <mst@redhat.com> - 2016-02-10 12:50 +0100
  Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the  core code Greg Kurz <gkurz@linux.vnet.ibm.com> - 2016-02-10 14:10 +0100
    Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the  core code Cornelia Huck <cornelia.huck@de.ibm.com> - 2016-02-10 14:30 +0100
      Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the  core code Greg Kurz <gkurz@linux.vnet.ibm.com> - 2016-02-10 14:50 +0100

csiph-web