Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode
Date	2016-02-10 15:30 +0100
Message-ID	<r0DWj-3jE-31@gated-at.bofh.it> (permalink)
References	<qYOj8-ED-9@gated-at.bofh.it> <qYOj8-ED-7@gated-at.bofh.it> <r0C4a-28R-1@gated-at.bofh.it> <r0CdQ-2bY-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 10, 2016 at 01:29:31PM +0100, Jiri Olsa wrote:
> On Wed, Feb 10, 2016 at 01:23:45PM +0100, Jiri Olsa wrote:
> > On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote:
> > 
> > SNIP
> > 
> > >  
> > > -	for (nd = rb_first(&hists->entries); nd; nd = rb_next(nd)) {
> > > +	for (nd = rb_first(&hists->entries); nd; nd = rb_hierarchy_next(nd)) {
> > >  		struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node);
> > >  		float percent;
> > >  
> > > @@ -542,6 +614,9 @@ print_entries:
> > >  						   MAP__FUNCTION, fp);
> > >  			fprintf(fp, "%.10s end\n", graph_dotted_line);
> > >  		}
> > > +
> > > +		if (symbol_conf.report_hierarchy)
> > > +			h->unfolded = true;
> > 
> > what's this for?
> > 
> 
> ah it's stdio, we need to show everything.. ok ;-)

Right. :)

> 
> I was thinking of putting this 'force un/fold' logic into the
> rb_hierarchy_next interface, because it's also not nice in
> hists__filter_hierarchy function..
> 
> maybe having extra argument telling the walk preference
> would be easier to read, like:
> 
>   rb_hierarchy_next(&h->rb_node, FORCE_UNFOLD);
>   rb_hierarchy_next(&h->rb_node, FORCE_FOLD);
>   rb_hierarchy_next(&h->rb_node, DEFAULT);
> 
> with some better names of course
> 
> just an idea.. it might turn horrible as well ;-)

Seems like a good idea.  I'll think about it in the next spin.

Thanks,
Namhyung

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode Jiri Olsa <jolsa@redhat.com> - 2016-02-10 13:30 +0100
  Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode Jiri Olsa <jolsa@redhat.com> - 2016-02-10 13:40 +0100
    Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode Namhyung Kim <namhyung@kernel.org> - 2016-02-10 15:30 +0100

csiph-web