Re: [PATCH v2 2/3] mm/compaction: pass only pageblock aligned range to pageblock_pfn_to_page

From	Vlastimil Babka <vbabka@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] mm/compaction: pass only pageblock aligned range to pageblock_pfn_to_page
Date	2016-02-10 14:00 +0100
Message-ID	<r0Cxd-2iO-9@gated-at.bofh.it> (permalink)
References	<qYlqN-4PS-3@gated-at.bofh.it> <qYlqN-4PS-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/04/2016 07:19 AM, Joonsoo Kim wrote:
> pageblock_pfn_to_page() is used to check there is valid pfn and all pages
> in the pageblock is in a single zone. If there is a hole in the pageblock,
> passing arbitrary position to pageblock_pfn_to_page() could cause to skip
> whole pageblock scanning, instead of just skipping the hole page. For
> deterministic behaviour, it's better to always pass pageblock aligned
> range to pageblock_pfn_to_page(). It will also help further optimization
> on pageblock_pfn_to_page() in the following patch.
> 
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/3] mm/compaction: pass only pageblock aligned range  to pageblock_pfn_to_page Vlastimil Babka <vbabka@suse.cz> - 2016-02-10 14:00 +0100

csiph-web