Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1331130

Re: [PATCH] mfd: Provide MACRO to declare commonly defined MFD cell attributes

From Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mfd: Provide MACRO to declare commonly defined MFD cell attributes
Date 2016-02-10 14:00 +0100
Message-ID <r0Cxd-2iO-5@gated-at.bofh.it> (permalink)
References <r0hsK-5dn-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tuesday 09 February 2016 07:57 PM, Lee Jones wrote:
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>   include/linux/mfd/core.h | 32 ++++++++++++++++++++++++++++++++
>   1 file changed, 32 insertions(+)
>
> diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
> index 27dac3f..dacdc49 100644
> --- a/include/linux/mfd/core.h
> +++ b/include/linux/mfd/core.h
> @@ -16,6 +16,38 @@
>   
>   #include <linux/platform_device.h>
>   
> +#define MFD_CELL_ALL(_name, _res, _pdata, _id, _compat, _match)		\
> +	{								\
> +		.name = (_name),					\
> +		.num_resources = ARRAY_SIZE((_res)),			\
> +		.resources = (_res),					\
> +		.platform_data = (_pdata),				\
> +		.pdata_size = ARRAY_SIZE((_pdata)),			\
> +		.of_compatible = (_compat),				\
> +		.acpi_match = (_match),					\
> +		.id = _id,						\
> +	}
>

Should we add the _res_size and _pdata_size also in argument and use 
them instead of ARRA_SIZE and lets client set the size with help of 
ARRAY_SIZE based on type of data?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mfd: Provide MACRO to declare commonly defined MFD cell attributes Lee Jones <lee.jones@linaro.org> - 2016-02-09 15:30 +0100
  Re: [PATCH] mfd: Provide MACRO to declare commonly defined MFD cell  attributes Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-09 16:40 +0100
  Re: [PATCH] mfd: Provide MACRO to declare commonly defined MFD cell  attributes Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-10 14:00 +0100
  [PATCH v2] mfd: Provide MACRO to declare commonly defined MFD cell  attributes Lee Jones <lee.jones@linaro.org> - 2016-02-10 16:40 +0100
    Re: [PATCH v2] mfd: Provide MACRO to declare commonly defined MFD  cell attributes Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-10 19:10 +0100
      Re: [PATCH v2] mfd: Provide MACRO to declare commonly defined MFD  cell attributes Lee Jones <lee.jones@linaro.org> - 2016-02-11 10:20 +0100
        Re: [PATCH v2] mfd: Provide MACRO to declare commonly defined MFD  cell attributes Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-11 10:20 +0100
          Re: [PATCH v2] mfd: Provide MACRO to declare commonly defined MFD  cell attributes Lee Jones <lee.jones@linaro.org> - 2016-02-11 10:50 +0100
  [PATCH v2] mfd: ab8500: Provide a small example using new MFD cell  MACROs Lee Jones <lee.jones@linaro.org> - 2016-02-10 16:40 +0100
    Re: [PATCH v2] mfd: ab8500: Provide a small example using new MFD  cell MACROs Linus Walleij <linus.walleij@linaro.org> - 2016-02-15 11:00 +0100

csiph-web