Re: [PATCH v4 2/4] modules: set mod->state to MODULE_STATE_GOING before going notifiers are called

From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/4] modules: set mod->state to MODULE_STATE_GOING before going notifiers are called
Date	2016-02-10 13:40 +0100
Message-ID	<r0CdQ-2bY-7@gated-at.bofh.it> (permalink)
References	<r08z8-7uB-1@gated-at.bofh.it> <r08z8-7uB-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon 2016-02-08 23:50:22, Jessica Yu wrote:
> In load_module(), the going notifiers are called during error handling when
> an error occurs after the coming notifiers have already been called.
> However, a module's state is still MODULE_STATE_COMING when the going
> notifiers are called in the error path. To be consistent, also set
> mod->state to MODULE_STATE_GOING before calling the going notifiers.
> 
> Signed-off-by: Jessica Yu <jeyu@redhat.com>

Reviewed-by: Petr Mladek <pmladek@suse.com>

It makes perfect sense to set the state this way. But note that it is
only partial win. We still stay in the COMING state when using the
other goto targets for the error handling, e.g. bug_cleanup,
ddebug_cleanup.

I was a bit nervous by such a change at this stage of 4.5 release.
I spent quite some time on checking various scenarios and I did
not find any problem with it.

Best Regards,
Petr

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4 2/4] modules: set mod->state to MODULE_STATE_GOING  before going notifiers are called Petr Mladek <pmladek@suse.com> - 2016-02-10 13:40 +0100

csiph-web