Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331105

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

Show all headers | View raw

On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote:

SNIP

> +	printed += fprintf(fp, "%s\n", buf);
> +
> +	if (symbol_conf.use_callchain && he->leaf) {
> +		u64 total = hists__total_period(hists);
> +
> +		printed += hist_entry_callchain__fprintf(he, total, 0, fp);
> +		goto out;
> +	}
> +
> +out:
> +	return printed;
> +}
> +
>  static int hist_entry__fprintf(struct hist_entry *he, size_t size,
>  			       struct hists *hists,
>  			       char *bf, size_t bfsz, FILE *fp)
> @@ -423,6 +488,13 @@ static int hist_entry__fprintf(struct hist_entry *he, size_t size,
>  	if (size == 0 || size > bfsz)
>  		size = hpp.size = bfsz;
>  
> +	if (symbol_conf.report_hierarchy) {

it'd be great for review to have symbol_conf.report_hierarchy already
present, so I could try it early in the patchset like with this change

jirka

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode Jiri Olsa <jolsa@redhat.com> - 2016-02-10 13:20 +0100
  Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode Namhyung Kim <namhyung@kernel.org> - 2016-02-10 15:30 +0100

csiph-web