[PATCH] cpufreq: governor: Drop pointless goto from cpufreq_governor_init()

From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	[PATCH] cpufreq: governor: Drop pointless goto from cpufreq_governor_init()
Date	2016-02-09 00:00 +0100
Message-ID	<r02WL-3dj-23@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

It is silly to jump around "return 0", so don't do that.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

On top of the bleeding-edge branch of linux-pm.git.

Thanks,
Rafael

---
 drivers/cpufreq/cpufreq_governor.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Index: linux-pm/drivers/cpufreq/cpufreq_governor.c
===================================================================
--- linux-pm.orig/drivers/cpufreq/cpufreq_governor.c
+++ linux-pm/drivers/cpufreq/cpufreq_governor.c
@@ -394,12 +394,11 @@ static int cpufreq_governor_init(struct
 
 	ret = sysfs_create_group(get_governor_parent_kobj(policy),
 				 get_sysfs_attr(gov));
-	if (ret)
-		goto reset_gdbs_data;
+	if (!ret)
+		return 0;
 
-	return 0;
+	/* Failure, so roll back. */
 
-reset_gdbs_data:
 	policy->governor_data = NULL;
 
 	if (!have_governor_per_policy())

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: governor: Drop pointless goto from cpufreq_governor_init() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-09 00:00 +0100
  Re: [PATCH] cpufreq: governor: Drop pointless goto from  cpufreq_governor_init() Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-09 05:00 +0100

csiph-web