Re: [PATCH 1/3] nfit: fix multi-interface dimm handling, acpi6.1 compatibility

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] nfit: fix multi-interface dimm handling, acpi6.1 compatibility
Date	2016-02-08 21:40 +0100
Message-ID	<r00Lh-1TO-23@gated-at.bofh.it> (permalink)
References	<qZYT7-Dx-1@gated-at.bofh.it> <qZYT9-Dx-33@gated-at.bofh.it> <qZZvQ-19R-3@gated-at.bofh.it> <r00BA-1PS-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 8, 2016 at 12:23 PM, Linda Knippers <linda.knippers@hpe.com> wrote:
> On 2/8/2016 2:10 PM, Linda Knippers wrote:
>> On 2/8/2016 1:30 PM, Dan Williams wrote:
>>> ACPI 6.1 clarified that multi-interface dimms require multiple control
>>> region entries (DCRs) per dimm.  Previously we were assuming that a
>>> control region is only present when block-data-windows are present.
>>
>> We need to give this a quick test with NVDIMM-N because those types of
>> NVDIMMs have control regions without block-data-windows.  We've fixed
>> bugs related to that assumption a couple of times.
>
> I can't test the conditions for which these changes were made but the
> code continues to work on my NVDIMM-N system where we have control
> regions w/o block-data windows.
>

Nice, thanks for the test report!  For my part I verified that the
implementation passes the original plus the modified unit test as
updated in [PATCH 3/3].

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] ACPI 6.1 NFIT Compatibility Dan Williams <dan.j.williams@intel.com> - 2016-02-08 19:40 +0100
  [PATCH 2/3] nfit,  tools/testing/nvdimm: add format interface code definitions Dan Williams <dan.j.williams@intel.com> - 2016-02-08 19:40 +0100
  [PATCH 3/3] nfit,  tools/testing/nvdimm: test multiple control regions per-dimm Dan Williams <dan.j.williams@intel.com> - 2016-02-08 19:40 +0100
  [PATCH 1/3] nfit: fix multi-interface dimm handling,  acpi6.1 compatibility Dan Williams <dan.j.williams@intel.com> - 2016-02-08 19:40 +0100
    Re: [PATCH 1/3] nfit: fix multi-interface dimm handling, acpi6.1  compatibility Linda Knippers <linda.knippers@hpe.com> - 2016-02-08 20:20 +0100
      Re: [PATCH 1/3] nfit: fix multi-interface dimm handling, acpi6.1  compatibility Linda Knippers <linda.knippers@hpe.com> - 2016-02-08 21:30 +0100
        Re: [PATCH 1/3] nfit: fix multi-interface dimm handling, acpi6.1 compatibility Dan Williams <dan.j.williams@intel.com> - 2016-02-08 21:40 +0100

csiph-web