Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1278952

Re: [RFC PATCH 02/15] PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver

Show all headers | View raw

On Thu, Nov 26, 2015 at 10:47:26PM +0900, Chanwoo Choi wrote:
> This patch adds the documentation for generic exynos bus frequency
> driver.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  .../devicetree/bindings/devfreq/exynos-bus.txt     | 92 ++++++++++++++++++++++
>  1 file changed, 92 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> 
> diff --git a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> new file mode 100644
> index 000000000000..5d90623bd173
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> @@ -0,0 +1,92 @@
> +* Generic Exynos Bus frequency device
> +
> +The Samsung Exynos SoC have many buses for data transfer between DRAM
> +and sub-blocks in SoC. Almost Exynos SoC have the common architecture
> +for buses. Generally, the each bus of Exynos SoC includes the source clock
> +and power line and then is able to change the clock according to the usage
> +of each buses on runtime. When gathering the usage of each buses on runtime,
> +thie driver uses the exynos-ppmu.c driver with DEVFREQ-EVENT framework.

Please don't refer to Linux subsystem specifics in bindings. It looks 
like you are creating devices to match what you have for drivers, not 
what the h/w looks like.


> +There are a little different composition among Exynos SoC because each Exynos
> +SoC has the different sub-blocks. So, this difference should be specified
> +in devicetree file instead of each device driver. In result, this driver
> +is able to support the bus frequency for all Exynos SoCs.
> +
> +Required properties for bus device:
> +- compatible: Should be "samsung,exynos-bus".
> +- clock-names : the name of clock used by the bus, "bus".
> +- clocks : phandles for clock specified in "clock-names" property.
> +- #clock-cells: should be 1.
> +- operating-points-v2: the OPP table including frequency/voltage information
> +  to support DVFS (Dynamic Voltage/Frequency Scaling) feature.
> +- vdd-supply: the regulator to provide the buses with the voltage.
> +- devfreq-events: the devfreq-event device to monitor the curret utilization
> +  of buses.
> +
> +Optional properties for bus device:
> +- exynos,saturation-ratio: the percentage value which is used to calibrate
> +                   the performance count againt total cycle count.
> +
> +Example1:
> +	Show the AXI buses of Exynos3250 SoC. Exynos3250 divides the buses to
> +	power line (regulator). The MIF (Memory Interface) AXI bus is used to
> +	transfer data between DRAM and CPU and uses the VDD_MIF regualtor.
> +
> +	- power line(VDD_MIF) --> bus for DMC block (dmc clock)
> +
> +	- MIF bus's frequency/voltage table
> +	-----------------------
> +	|Lv| Freq   | Voltage |
> +	-----------------------
> +	|L1| 50000  |800000   |
> +	|L2| 100000 |800000   |
> +	|L3| 133000 |800000   |
> +	|L4| 200000 |800000   |
> +	|L5| 400000 |875000   |
> +	-----------------------
> +
> +Example2 :
> +	The bus of DMC block in exynos3250.dtsi are listed below:

What is DMC?

> +
> +	bus_dmc: bus_dmc {
> +		compatible = "samsung,exynos-bus";

I would expect the children of this bus to be under this node.

> +		clocks = <&cmu_dmc CLK_DIV_DMC>;
> +		clock-names = "bus";
> +		operating-points-v2 = <&bus_dmc_opp_table>;
> +		status = "disabled";
> +	};
> +
> +	bus_dmc_opp_table: opp_table0 {
> +		compatible = "operating-points-v2";
> +		opp-shared;
> +
> +		opp00 {
> +			opp-hz = /bits/ 64 <50000000>;
> +			opp-microvolt = <800000>;
> +		};
> +		opp01 {
> +			opp-hz = /bits/ 64 <100000000>;
> +			opp-microvolt = <800000>;
> +		};
> +		opp02 {
> +			opp-hz = /bits/ 64 <133000000>;
> +			opp-microvolt = <800000>;
> +		};
> +		opp03 {
> +			opp-hz = /bits/ 64 <200000000>;
> +			opp-microvolt = <800000>;
> +		};
> +		opp04 {
> +			opp-hz = /bits/ 64 <400000000>;
> +			opp-microvolt = <875000>;
> +		};
> +	};
> +
> +	Usage case to handle the frequency and voltage of bus on runtime
> +	in exynos3250-rinato.dts are listed below:
> +
> +	&bus_dmc {
> +		devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;

What do these phandles point to exactly?

> +		vdd-supply = <&buck1_reg>;	/* VDD_MIF */
> +		status = "okay";
> +	};
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 00/15] PM / devferq: Add generic exynos bus frequency  driver and new passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-26 14:50 +0100
  [RFC PATCH 12/15] ARM: dts: Add support of bus frequency using VDD_INT  for exynos3250-rinato Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-26 14:50 +0100
  [RFC PATCH 07/15] PM / devfreq: Show the related information according  to governor type Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-26 14:50 +0100
  [RFC PATCH 14/15] ARM: dts: Add bus nodes using VDD_INT for Exynos4x12 Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-26 14:50 +0100
  [RFC PATCH 03/15] ARM: dts: Add DMC bus node for Exynos3250 Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-26 14:50 +0100
  [RFC PATCH 08/15] PM / devfreq: exynos: Add support of bus frequency  of sub-blocks using passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-26 15:00 +0100
  [RFC PATCH 11/15] ARM: dts: Add bus nodes using VDD_INT for Exynos3250 Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-26 15:00 +0100
  [RFC PATCH 02/15] PM / devfreq: exynos: Add documentation for generic  exynos bus frequency driver Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-26 15:00 +0100
    Re: [RFC PATCH 02/15] PM / devfreq: exynos: Add documentation for  generic exynos bus frequency driver Rob Herring <robh@kernel.org> - 2015-11-27 21:40 +0100
      Re: [RFC PATCH 02/15] PM / devfreq: exynos: Add documentation for  generic exynos bus frequency driver Chanwoo Choi <cwchoi00@gmail.com> - 2015-11-28 03:20 +0100
  [RFC PATCH 06/15] PM / devfreq: Add devfreq_get_devfreq_by_phandle() Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-26 15:00 +0100
  [RFC PATCH 01/15] PM / devfreq: exynos: Add generic exynos bus  frequency driver Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-26 15:00 +0100
    Re: [RFC PATCH 01/15] PM / devfreq: exynos: Add generic exynos bus  frequency driver MyungJoo Ham <myungjoo.ham@samsung.com> - 2015-11-26 15:10 +0100
      Re: [RFC PATCH 01/15] PM / devfreq: exynos: Add generic exynos bus  frequency driver Chanwoo Choi <cwchoi00@gmail.com> - 2015-11-26 17:20 +0100
        Re: [RFC PATCH 01/15] PM / devfreq: exynos: Add generic exynos bus  frequency driver Anand Moon <linux.amoon@gmail.com> - 2015-11-26 18:20 +0100
          Re: [RFC PATCH 01/15] PM / devfreq: exynos: Add generic exynos bus  frequency driver Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-27 01:40 +0100
  [RFC PATCH 05/15] PM / devfreq: Add new passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-26 15:00 +0100
  [RFC PATCH 09/15] PM / devfreq: exynos: Update documentation for bus  devices using passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-26 15:00 +0100

csiph-web