Re: [PATCH v4 4/5] clk: qcom: Add RPM clock controller driver

From	Bjorn Andersson <bjorn@kryo.se>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 4/5] clk: qcom: Add RPM clock controller driver
Date	2015-11-27 17:30 +0100
Message-ID	<qzu4i-5gq-7@gated-at.bofh.it> (permalink)
References	<qwxUK-1Bc-3@gated-at.bofh.it> <qwxUK-1Bc-5@gated-at.bofh.it> <qx4xj-6i8-1@gated-at.bofh.it> <qxspX-5BE-1@gated-at.bofh.it> <qya7D-Sp-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 23, 2015 at 4:59 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 11/21, Bjorn Andersson wrote:
>> On Fri 20 Nov 16:39 PST 2015, Stephen Boyd wrote:
[..]
>> Do you foresee that there will be an implementation of the generic rpmcc
>> or is it just a way to "standardize" the dt binding?
>>
>
> I don't see any problem with implementing the RPM clock
> controller as one file or two files (one for platform bus based
> RPM modules and one for SMD bus RPM modules). The compatible can
> be the same for both struct driver instances, while the bus will
> pick the right driver. I suspect we'll need SoC specific
> compatibles though to export the right set of clocks, so having
> the generic compatible is mostly to find these rpm clock
> controllers so that we know to skip registering the XO clock from
> the GCC driver and not some generic implementation of the driver.
>

Ahh, now I get it. So the generic rpmcc to be able to check if we have
a rpmcc instance and then the specific for the actual implementation.

I'm +1 on that.

> There's probably a subset of the clocks that's always the same
> between devices, so if we had to we could match the generic
> compatible and provide limited functionality.
>

After looking at a couple of platforms I don't think it's worth the
effort of having a common list of rpm clocks. My suggestion is that we
just continue with the suggested approach (having platform specific
rpmcc defines and tables)

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 4/5] clk: qcom: Add RPM clock controller driver Georgi Djakov <georgi.djakov@linaro.org> - 2015-11-19 15:00 +0100
  Re: [PATCH v4 4/5] clk: qcom: Add RPM clock controller driver Stephen Boyd <sboyd@codeaurora.org> - 2015-11-21 01:50 +0100
    Re: [PATCH v4 4/5] clk: qcom: Add RPM clock controller driver Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-11-22 03:20 +0100
      Re: [PATCH v4 4/5] clk: qcom: Add RPM clock controller driver Stephen Boyd <sboyd@codeaurora.org> - 2015-11-24 02:00 +0100
        Re: [PATCH v4 4/5] clk: qcom: Add RPM clock controller driver Bjorn Andersson <bjorn@kryo.se> - 2015-11-27 17:30 +0100

csiph-web