Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1278867

Re: [PATCH v10] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller

Show all headers | View raw

On Friday 27 November 2015 20:32:03 Bharat Kumar Gogada wrote:
> +       do {
> +               err = nwl_pcie_link_up(pcie, PHY_RDY_LINKUP);
> +               if (err != 1) {
> +                       check_link_up++;
> +                       if (check_link_up > LINKUP_ITER_CHECK)
> +                               return -ENODEV;
> +                       mdelay(1000);
> +               }
> +       } while (!err);

mdelay(1000) is not something anyone should do. Why can't you call
a sleeping function here?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v10] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com> - 2015-11-27 16:10 +0100
  Re: [PATCH v10] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL  PCIe Host Controller Marc Zyngier <marc.zyngier@arm.com> - 2015-11-27 16:40 +0100
    RE: [PATCH v10] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL  PCIe Host Controller Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com> - 2015-11-28 11:00 +0100
  Re: [PATCH v10] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller Arnd Bergmann <arnd@arndb.de> - 2015-11-27 17:00 +0100
    RE: [PATCH v10] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL  PCIe Host Controller Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com> - 2015-11-28 11:00 +0100

csiph-web