Re: [PATCH] logfs: clarify MTD dependency

From	Michal Marek <mmarek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] logfs: clarify MTD dependency
Date	2015-11-27 16:00 +0100
Message-ID	<qzsFc-4dB-21@gated-at.bofh.it> (permalink)
References	<qzrJ8-3Bb-21@gated-at.bofh.it> <qzs2u-3Zb-23@gated-at.bofh.it> <qzslP-471-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2015-11-27 15:30, Arnd Bergmann wrote:
> On Friday 27 November 2015 15:14:06 Michal Marek wrote:
>>
>> Hi Arnd,
>>
>> I hit this as well and was about to submit a slightly different fix. Can
>> you try the logfs portion of the below patch? Proper changelog is to be
>> done, but the gist of the patch is that IS_REACHABLE(CONFIG_FOO) 
>> evaluates to 1 if CONFIG_FOO=y or we are building a module and
>> CONFIG_FOO=m.
>>
> 
> I thought about doing it that way, and I'm sure that also worked.
> The possible behaviors are basically:
> 
> a) before your original patch, building logfs with CONFIG_MTD=m would
>    silently leave out MTD support, which was rather confusing.
> 
> b) with my patch, it becomes impossible to have logfs as the built-in
>    root file system on a block device while also using CONFIG_MTD=m,
>    and that may be slightly annoying
> 
> c) your patch restores a), but makes it work in the case where both
>    logfs and mtd are loadable modules, which is an improvement but
>    may still confuse users.
> 
> My preference is still version b) as I sent, but I don't really mind
> your version either.

I used the IS_REACHABLE macro because it hides the boolean expressions
nicely :). But I also do not insist on a particular solution. Jörn, what
would be your preference?

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] logfs: clarify MTD dependency Arnd Bergmann <arnd@arndb.de> - 2015-11-27 15:00 +0100
  Re: [PATCH] logfs: clarify MTD dependency Michal Marek <mmarek@suse.com> - 2015-11-27 15:20 +0100
    Re: [PATCH] logfs: clarify MTD dependency Arnd Bergmann <arnd@arndb.de> - 2015-11-27 15:40 +0100
      Re: [PATCH] logfs: clarify MTD dependency Michal Marek <mmarek@suse.com> - 2015-11-27 16:00 +0100

csiph-web