Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1278798
| From | Minfei Huang <mnfhuang@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/2] null_blk: Remove null block from list in error path |
| Date | 2015-11-27 14:30 +0100 |
| Message-ID | <qzrg5-3nT-5@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
To make consistent of null block list, we should remove enqueued null block from the list before freeing it. Signed-off-by: Minfei Huang <mnfhuang@gmail.com> --- drivers/block/null_blk.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c index ec99568..729ecd7 100644 --- a/drivers/block/null_blk.c +++ b/drivers/block/null_blk.c @@ -738,7 +738,7 @@ static int null_add_dev(void) rv = nvm_register(nullb->q, nullb->disk_name, &null_lnvm_dev_ops); if (rv) - goto out_cleanup_blk_queue; + goto out_cleanup_blk_list; goto done; } @@ -765,6 +765,10 @@ done: out_cleanup_lightnvm: if (use_lightnvm) nvm_unregister(nullb->disk_name); +out_cleanup_blk_list: + mutex_lock(&lock); + list_del_init(&nullb->list); + mutex_unlock(&lock); out_cleanup_blk_queue: blk_cleanup_queue(nullb->q); out_cleanup_tags: -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 1/2] null_blk: Remove null block from list in error path Minfei Huang <mnfhuang@gmail.com> - 2015-11-27 14:30 +0100 [PATCH 2/2] null_blk: Do a cleanup for function null_add_dev Minfei Huang <mnfhuang@gmail.com> - 2015-11-27 14:30 +0100
csiph-web