Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1278710
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!border1.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Rasmus Villemoes <linux@rasmusvillemoes.dk> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/3] usb: musb: remove redundant stack buffer |
| Date | Fri, 27 Nov 2015 11:40:02 +0100 |
| Message-ID | <qzoBA-1DT-29@gated-at.bofh.it> (permalink) |
| References | <qzoBz-1DT-13@gated-at.bofh.it> |
| X-Original-To | Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LFcQku2hue2NYGnv9jt2xUnNQ1WH3ApqjhQM2hzQp+E=; b=dyb1yrM/kP2o5rvYhK47xKcWs7XTO8HFDf2UYikc/Syx66wtu9M3N5V49UNNyvRbHt 3RlHEBZvSWmzDzryinjI+Yl00MXfiRuaxlHaX/uWslbMwl6jIgw/ZN3j3FtcDv7t2m8y lYiQib1j4EiAXTLISFzbCFeJImEtz/i78sK/M= |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LFcQku2hue2NYGnv9jt2xUnNQ1WH3ApqjhQM2hzQp+E=; b=AaTrAZ//1CYFnU3WkNKK4gvHwZTr0L0oCZJdXk4ip8M7QXabuxHA4NoHEvCFjypfif r+dF54WExIZRWdJHTNR2f3L4dfB2fY/GZwAuXvvaGhESVn7eHJ0BT/JmnsTH0tI1r2mm hk2kTHlNAkxw+Ft3PubmF8X92iM0LZqvO/WrQpGHL9TjfxY9lj1kH9PrLBrUM1gDlxkV NEtZCFt/tmEjyjyJLQC1ESb2KRJEERfb41wY0Ti6KIcg8XbaY2SENXhm1iUOgpalXoBK PNqB4YqOleSqwjUY8uHLmwxhi0CuJDzzbPnpuvdWYj3mJDanVmeJhimHs1HTd3/UHHov yfiQ== |
| X-Gm-Message-State | ALoCoQn3fsUexQEb4V7tyhE8Uta0WYpRDbYQxCLOjceHhK6xwwWDi7yXS+GATOs+1EYQHNDiCC6d |
| X-Received | by 10.112.181.225 with SMTP id dz1mr15741322lbc.103.1448620712520; Fri, 27 Nov 2015 02:38:32 -0800 (PST) |
| X-Mailer | git-send-email 2.6.1 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 47 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Fri, 27 Nov 2015 11:38:23 +0100 |
| X-Original-Message-ID | <1448620703-13101-3-git-send-email-linux@rasmusvillemoes.dk> |
| X-Original-References | <1448620703-13101-1-git-send-email-linux@rasmusvillemoes.dk> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1278710 |
Show key headers only | View raw
aRevision is only used once, so we might as well do the formatting as
part of the pr_debug. This eliminates the stack buffer, and avoids
doing the formatting at all when pr_debug is compiled out.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/usb/musb/musb_core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 86dce9635b14..3e8d1bcfc1b5 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -1458,7 +1458,7 @@ static int musb_core_init(u16 musb_type, struct musb *musb)
{
u8 reg;
char *type;
- char aInfo[90], aRevision[32];
+ char aInfo[90];
void __iomem *mbase = musb->mregs;
int status = 0;
int i;
@@ -1506,11 +1506,11 @@ static int musb_core_init(u16 musb_type, struct musb *musb)
/* log release info */
musb->hwvers = musb_read_hwvers(mbase);
- snprintf(aRevision, 32, "%d.%d%s", MUSB_HWVERS_MAJOR(musb->hwvers),
- MUSB_HWVERS_MINOR(musb->hwvers),
- (musb->hwvers & MUSB_HWVERS_RC) ? "RC" : "");
- pr_debug("%s: %sHDRC RTL version %s\n",
- musb_driver_name, type, aRevision);
+ pr_debug("%s: %sHDRC RTL version %d.%d%s\n",
+ musb_driver_name, type,
+ MUSB_HWVERS_MAJOR(musb->hwvers),
+ MUSB_HWVERS_MINOR(musb->hwvers),
+ (musb->hwvers & MUSB_HWVERS_RC) ? "RC" : "");
/* configure ep0 */
musb_configure_ep0(musb);
--
2.6.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] usb: musb: convert printk to pr_* Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-27 11:40 +0100
[PATCH 3/3] usb: musb: remove redundant stack buffer Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-27 11:40 +0100
[PATCH 2/3] usb: musb: remove always-empty string from debug output Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-27 11:40 +0100
Re: [PATCH 1/3] usb: musb: convert printk to pr_* Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-27 13:30 +0100
Re: [PATCH 1/3] usb: musb: convert printk to pr_* Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-28 01:10 +0100
Re: [PATCH 1/3] usb: musb: convert printk to pr_* Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-28 11:30 +0100
csiph-web